unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Felipe Contreras <felipe.contreras@gmail.com>, notmuch@notmuchmail.org
Cc: Felipe Contreras <felipe.contreras@gmail.com>
Subject: Re: [PATCH 0/2] ruby: sync database close/destroy
Date: Mon, 02 Aug 2021 14:24:50 -0300	[thread overview]
Message-ID: <87fsvrzrml.fsf@tethera.net> (raw)
In-Reply-To: <20210707034533.3137309-1-felipe.contreras@gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

> Sychronize with notmuch API, where notmuch_database_close is different
> from notmuch_database_destroy. At least since a long time ago.
>

First patch applied to master.

Second patch seems to have too much fuzz to apply; I guess some changes
to defs.h were applied in a different order to master than in your
branch?

Anyway, content of second patch is fine too, can you rebase?

d

  parent reply	other threads:[~2021-08-02 17:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-07  3:45 [PATCH 0/2] ruby: sync database close/destroy Felipe Contreras
2021-07-07  3:45 ` [PATCH 1/2] ruby: split database close and destroy Felipe Contreras
2021-07-07  3:45 ` [PATCH 2/2] ruby: cleanup object_destroy() Felipe Contreras
2021-08-02 17:24 ` David Bremner [this message]
2021-08-03 18:44   ` [PATCH v2] " Felipe Contreras
2021-08-04  1:46     ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fsvrzrml.fsf@tethera.net \
    --to=david@tethera.net \
    --cc=felipe.contreras@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).