From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id AM3DAGsqCGEKLgEAgWs5BA (envelope-from ) for ; Mon, 02 Aug 2021 19:24:59 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 0HXrN2oqCGGFBQAAbx9fmQ (envelope-from ) for ; Mon, 02 Aug 2021 17:24:58 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AC2896A66 for ; Mon, 2 Aug 2021 19:24:58 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 3FDAC2C06C; Mon, 2 Aug 2021 13:24:55 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id BBBDE2C062 for ; Mon, 2 Aug 2021 13:24:51 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id 9808F5FD5C; Mon, 2 Aug 2021 13:24:51 -0400 (EDT) Received: (nullmailer pid 3270859 invoked by uid 1000); Mon, 02 Aug 2021 17:24:50 -0000 From: David Bremner To: Felipe Contreras , notmuch@notmuchmail.org Cc: Felipe Contreras Subject: Re: [PATCH 0/2] ruby: sync database close/destroy In-Reply-To: <20210707034533.3137309-1-felipe.contreras@gmail.com> References: <20210707034533.3137309-1-felipe.contreras@gmail.com> Date: Mon, 02 Aug 2021 14:24:50 -0300 Message-ID: <87fsvrzrml.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: LTNFNCBQOELMZRTSH7YVO7T5MF366IT7 X-Message-ID-Hash: LTNFNCBQOELMZRTSH7YVO7T5MF366IT7 X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1627925098; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Grva6MbFgoAnefawGNCm0Z9l9oxxZ5Oth0pCU1aumsc=; b=aY3Dwx0lApycAAFX9yEAqjBwSXetvo4KUrntmr8xVs9H5oFpNlL8clTM4D2qoMbHBeH1Ie vP810bXKR8aFsoP0xzxxwJY/83cDrpfxo5Z4sRux5nhwpG9ZVmiOrLx+7uhq5fm4IGbwLg jggv5xY5rIn7CVi0BRlhDhoVTGBCIX1s1d6v8bRZ5MH3t2HAs+p0YZ0IBeNZO1FeCO+MI1 isGAL1qypVWRh+aG4KEJP597HrYExoZqXyas+qxAlf4b6MnwH2Pc23uQLVJF/OCihVDips 75TiIIciJgcHvwymF3TWHVB47qYOH0cDs2Auc8KEzu+JlIC6jeBFyxOSSAh5Lg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1627925098; a=rsa-sha256; cv=none; b=n+6a0NNkt+D/lIu5L8uZhmbxV8uFIyH/bS2zuD2Cu7L7NVTQ9tl0eGYh+VmkgqjnokRGMY 6A4uRr6IcysB3Wq/OZLdpZj/RRawpYsfplklAIWtlFWyD+5c8OaBKBpjnZcR047bsog9ZZ tPG0DaDsi2rxPIlzv6YI5XTb069RgoUUNotmRf+lB0Al2dTYqdkNn+HjintEksOTvqctAk BbeyDOiX9auaUVaC5pp33ywWGKuSsE0/iX6rFK0QDs/BbsdGRk75ZoO1OPazyd992zqILi 5Pp6uafz5Xkc7m96LnYhruSiWrMnWX6v8I66Ctf3oYYZTn3Cuv4dimJ83dr9Qg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -0.51 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: AC2896A66 X-Spam-Score: -0.51 X-Migadu-Scanner: scn1.migadu.com X-TUID: APHR8fmpS6oO Felipe Contreras writes: > Sychronize with notmuch API, where notmuch_database_close is different > from notmuch_database_destroy. At least since a long time ago. > First patch applied to master. Second patch seems to have too much fuzz to apply; I guess some changes to defs.h were applied in a different order to master than in your branch? Anyway, content of second patch is fine too, can you rebase? d