From: David Bremner <david@tethera.net>
To: "Jose A. Ortega Ruiz" <jao@gnu.org>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH v9] emacs: notmuch-tree-outline-mode
Date: Mon, 20 Feb 2023 09:16:11 -0400 [thread overview]
Message-ID: <87fsb0v5no.fsf@tethera.net> (raw)
In-Reply-To: <877cye2lp8.fsf@mail.jao.io>
"Jose A. Ortega Ruiz" <jao@gnu.org> writes:
> On Mon, Dec 26 2022, David Bremner wrote:
>
>> Amended by db: Copy docstring to manual and edit for presentation. Add
>> two tests.
>
> Thanks for the grunt work, David. Just a comment on a sloppy comment of
> mine below:
>
>> --- a/emacs/notmuch-tree.el
>> +++ b/emacs/notmuch-tree.el
>> @@ -1014,7 +1014,10 @@ unchanged ADDRESS if parsing fails."
>> A message tree is another name for a single sub-thread: i.e., a
>> message together with all its descendents."
>> (let ((msg (car tree))
>> - (replies (cadr tree)))
>> + (replies (cadr tree))
>> + ;; outline level, computed from the message's depth and
>> + ;; wether or not it's the first message in the tree.
>
> typo: whether
Applied to master, with that fix.
d
prev parent reply other threads:[~2023-02-20 13:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 2:15 [PATCH v8] emacs: notmuch-tree-outline-mode jao
2022-12-26 15:08 ` [PATCH v9] " David Bremner
2022-12-26 16:06 ` Jose A. Ortega Ruiz
2023-02-20 13:16 ` David Bremner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsb0v5no.fsf@tethera.net \
--to=david@tethera.net \
--cc=jao@gnu.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).