From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id SBXfDqNy82OJWgAAbAwnHQ (envelope-from ) for ; Mon, 20 Feb 2023 14:16:19 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id KJHnDqNy82OBFgEA9RJhRA (envelope-from ) for ; Mon, 20 Feb 2023 14:16:19 +0100 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 154CBA061 for ; Mon, 20 Feb 2023 14:16:18 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id AB6505F424; Mon, 20 Feb 2023 13:16:16 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 878435F380 for ; Mon, 20 Feb 2023 13:16:13 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1001) id 80B855FB9E; Mon, 20 Feb 2023 08:16:12 -0500 (EST) Received: (nullmailer pid 3515756 invoked by uid 1000); Mon, 20 Feb 2023 13:16:11 -0000 From: David Bremner To: "Jose A. Ortega Ruiz" Subject: Re: [PATCH v9] emacs: notmuch-tree-outline-mode In-Reply-To: <877cye2lp8.fsf@mail.jao.io> References: <20221213021542.1320339-1-jao@gnu.org> <20221226150821.3300399-1-david@tethera.net> <877cye2lp8.fsf@mail.jao.io> Date: Mon, 20 Feb 2023 09:16:11 -0400 Message-ID: <87fsb0v5no.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: KZICOGOVE7EICEKXCQCMV4IANJOSVZI2 X-Message-ID-Hash: KZICOGOVE7EICEKXCQCMV4IANJOSVZI2 X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: notmuch@notmuchmail.org X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Country: DE X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1676898979; a=rsa-sha256; cv=none; b=bcCbOTNRi7p3ACDruN++jI+pVdzS2OIUTfvJhL4a6bpTCWTH8osTmfk1MxtR2qZKT0/yDh T2ho2T5xV+54mUepFREwxMFO3g6xF+LXcCniwikCPUtPrXO2msUBzQUyHjaAt/qfY0H6mJ C1zm9M+l5zknu+q5R88lJCYPGsGvpZvlr1uPgbLvWy4ZDDhaCBSVrGMeUy+wrhddabVdFx Mn10ewD0sTVVoOVWewB2ahHxoySYRzccHt7+1ab/yZns9f/3TRUTIvZlphwqoOimGqv7w1 51R0r/SkJFXVeur4xvgV8SPBO27h2QxYrd7Sqwoga8/lWALBuQYBK4OY1UsXaw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1676898979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=42/6CngGiqo5v4ssSBw3/ALjOtlJL8DUy57omizlRq4=; b=d+W52S/550l90ELs9Y2mSbf1nrWeHhq7H867vpxL91+O78FKyfzbInvH2noXN1iH9aPfGC 5PVQRIVzJt8s4sPwh66nXLdHZ7ULigMxvWBazp+8nAuSwTO43Os9PMjZ2p5OvhQdpgCHyB +3UU6FoK6ag60FDj7MIoaqA1qpdOwzBLVXpHv3U2ljjnNQFHifVfTsGHeC9AY0o/zSHPf3 vyhJmu0tsn5ZDcERxonsx8pFsIcVQml48ZAclGiCQAlV0e4qUwQS2afUvaE+JiXqD/tlHz WDqqnUdItkeZNbTWwUeJkApxiRfgQDcdSSOgtKlZi6zkqMzgyz6zy7WFXTNNsw== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org; dmarc=none X-Spam-Score: -1.78 X-Migadu-Queue-Id: 154CBA061 X-Migadu-Spam-Score: -1.78 X-TUID: bcZOCPUK5ZAs "Jose A. Ortega Ruiz" writes: > On Mon, Dec 26 2022, David Bremner wrote: > >> Amended by db: Copy docstring to manual and edit for presentation. Add >> two tests. > > Thanks for the grunt work, David. Just a comment on a sloppy comment of > mine below: > >> --- a/emacs/notmuch-tree.el >> +++ b/emacs/notmuch-tree.el >> @@ -1014,7 +1014,10 @@ unchanged ADDRESS if parsing fails." >> A message tree is another name for a single sub-thread: i.e., a >> message together with all its descendents." >> (let ((msg (car tree)) >> - (replies (cadr tree))) >> + (replies (cadr tree)) >> + ;; outline level, computed from the message's depth and >> + ;; wether or not it's the first message in the tree. > > typo: whether Applied to master, with that fix. d