[PATCH] config: add quoting to fix IFS bug

[PATCH] config: add quoting to fix IFS bug

[Jameson Graef Rollins]

Without proper quoting the DEFAULT_IFS was getting set incorrectly,
which was causing problems with the storage of some variables later in
the script.  Quoting fixes the problem.
---
Thanks to Tomi for the inspiration for this fix.  I don't know how I
missed such a simple solution initially.

 configure |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 5602be2..3fad424 100755
--- a/configure
+++ b/configure
@@ -1,7 +1,7 @@
 #! /bin/sh
 
 # Store original IFS value so it can be changed (and restored) in many places.
-readonly DEFAULT_IFS=$IFS
+readonly DEFAULT_IFS="$IFS"
 
 srcdir=$(dirname "$0")
 
-- 
1.7.10

Re: [PATCH] config: add quoting to fix IFS bug

[Tomi Ollila]

On Sat, Jun 02 2012, Jameson Graef Rollins <jrollins@finestructure.net> wrote:

> Without proper quoting the DEFAULT_IFS was getting set incorrectly,
> which was causing problems with the storage of some variables later in
> the script.  Quoting fixes the problem.

LGTM

Tomi


> ---
> Thanks to Tomi for the inspiration for this fix.  I don't know how I
> missed such a simple solution initially.
>
>  configure |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 5602be2..3fad424 100755
> --- a/configure
> +++ b/configure
> @@ -1,7 +1,7 @@
>  #! /bin/sh
>  
>  # Store original IFS value so it can be changed (and restored) in many places.
> -readonly DEFAULT_IFS=$IFS
> +readonly DEFAULT_IFS="$IFS"
>  
>  srcdir=$(dirname "$0")
>  
> -- 
> 1.7.10
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] config: add quoting to fix IFS bug

[David Bremner]

Jameson Graef Rollins <jrollins@finestructure.net> writes:

> Without proper quoting the DEFAULT_IFS was getting set incorrectly,
> which was causing problems with the storage of some variables later in
> the script.  Quoting fixes the problem.

Pushed,

d