[PATCH 1/1] emacs: make editing a message as new include FCC

[PATCH 1/1] emacs: make editing a message as new include FCC

[Léo Gaspard]

---
 emacs/notmuch-draft.el | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/emacs/notmuch-draft.el b/emacs/notmuch-draft.el
index fb7f4f55..e22e0d16 100644
--- a/emacs/notmuch-draft.el
+++ b/emacs/notmuch-draft.el
@@ -2,6 +2,7 @@
 ;;
 ;; Copyright © Mark Walters
 ;; Copyright © David Bremner
+;; Copyright © Leo Gaspard
 ;;
 ;; This file is part of Notmuch.
 ;;
@@ -20,6 +21,7 @@
 ;;
 ;; Authors: Mark Walters <markwalters1009@gmail.com>
 ;;	    David Bremner <david@tethera.net>
+;;	    Leo Gaspard <leo@gaspard.io>
 
 ;;; Code:
 
@@ -225,7 +227,7 @@ applied to newly inserted messages)."
 			      "--exclude=false" id))
 	 (draft (equal tags (notmuch-update-tags tags notmuch-draft-tags))))
     (when (or draft
-	      (yes-or-no-p "Message does not appear to be a draft: really resume? "))
+	      (yes-or-no-p "Message does not appear to be a draft: edit as new? "))
       (switch-to-buffer (get-buffer-create (concat "*notmuch-draft-" id "*")))
       (setq buffer-read-only nil)
       (erase-buffer)
@@ -244,6 +246,7 @@ applied to newly inserted messages)."
 	  (message-remove-header "Message-ID"))
 	(when (member 'Date message-deletable-headers)
 	  (message-remove-header "Date"))
+	(unless draft (notmuch-fcc-header-setup))
 	;; The X-Notmuch-Emacs-Draft header is a more reliable
 	;; indication of whether the message really is a draft.
 	(setq draft (> (message-remove-header "X-Notmuch-Emacs-Draft") 0)))
-- 
2.18.1

[PATCH 0/1] Make emacs add FCC when editing a message as new

[notmuchmail.org]

From: Léo Gaspard <leo@gaspard.io>

Hello,

This patch changes the meaning of `e` for non-drafts to make it behave
similarly to new messages, which here means add the `FCC` header.

Disclaimer: it's the second non-trivial elisp expression I've ever
written, the first one currently being on the wiki [1], and which I'd be
happy if you checked I didn't do complete nonsense.

Thank you for your work on notmuch! I've been using it only for a few
days but it's being really great.
Leo

[1] https://notmuchmail.org/emacstips/#index24h2


Léo Gaspard (1):
  emacs: make editing a message as new include FCC

 emacs/notmuch-draft.el | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

-- 
2.18.1

[PATCH 1/1] emacs: make editing a message as new include FCC

[notmuchmail.org]

From: Léo Gaspard <leo@gaspard.io>

---
 emacs/notmuch-draft.el | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/emacs/notmuch-draft.el b/emacs/notmuch-draft.el
index fb7f4f55..e22e0d16 100644
--- a/emacs/notmuch-draft.el
+++ b/emacs/notmuch-draft.el
@@ -2,6 +2,7 @@
 ;;
 ;; Copyright © Mark Walters
 ;; Copyright © David Bremner
+;; Copyright © Leo Gaspard
 ;;
 ;; This file is part of Notmuch.
 ;;
@@ -20,6 +21,7 @@
 ;;
 ;; Authors: Mark Walters <markwalters1009@gmail.com>
 ;;	    David Bremner <david@tethera.net>
+;;	    Leo Gaspard <leo@gaspard.io>
 
 ;;; Code:
 
@@ -225,7 +227,7 @@ applied to newly inserted messages)."
 			      "--exclude=false" id))
 	 (draft (equal tags (notmuch-update-tags tags notmuch-draft-tags))))
     (when (or draft
-	      (yes-or-no-p "Message does not appear to be a draft: really resume? "))
+	      (yes-or-no-p "Message does not appear to be a draft: edit as new? "))
       (switch-to-buffer (get-buffer-create (concat "*notmuch-draft-" id "*")))
       (setq buffer-read-only nil)
       (erase-buffer)
@@ -244,6 +246,7 @@ applied to newly inserted messages)."
 	  (message-remove-header "Message-ID"))
 	(when (member 'Date message-deletable-headers)
 	  (message-remove-header "Date"))
+	(unless draft (notmuch-fcc-header-setup))
 	;; The X-Notmuch-Emacs-Draft header is a more reliable
 	;; indication of whether the message really is a draft.
 	(setq draft (> (message-remove-header "X-Notmuch-Emacs-Draft") 0)))
-- 
2.18.1

Re: [PATCH 1/1] emacs: make editing a message as new include FCC

[David Bremner]

notmuchmail.org@leo.gaspard.io writes:

> From: Léo Gaspard <leo@gaspard.io>
>

pushed, with some of the cover text copied into the commit message.

d