unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / Atom feed
* [PATCH] configure: replace $(realpath emacs) with $(cd emacs && pwd -P)
@ 2020-10-20  6:57 Tomi Ollila
  2020-10-21 10:15 ` David Bremner
  0 siblings, 1 reply; 2+ messages in thread
From: Tomi Ollila @ 2020-10-20  6:57 UTC (permalink / raw)
  To: notmuch; +Cc: tomi.ollila

For portability; the realpath command (e.g. from GNU coreutils)
is not so common outside Linux systems.

The "$(cd emacs && pwd -P)" replaces that realpath(1) execution
suitably in this context (using just bash(1) builtins).
---

Quotes ("") added for it to be better example for someone(tm) who
may look it while writing some other shell script elsewhere;
here, as $IFS characters are not (currently!) allowed in $PWD
those makes no difference...

 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 40e8b255..cfa9c09b 100755
--- a/configure
+++ b/configure
@@ -1536,7 +1536,7 @@ EOF
     if [ $WITH_PYTHON_DOCS = "1" ]; then
         echo "tags.add('WITH_PYTHON')"
     fi
-    printf "rsti_dir = '%s'\n" $(realpath emacs)
+    printf "rsti_dir = '%s'\n" "$(cd emacs && pwd -P)"
 } > sphinx.config
 
 # Finally, after everything configured, inform the user how to continue.
-- 
2.25.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] configure: replace $(realpath emacs) with $(cd emacs && pwd -P)
  2020-10-20  6:57 [PATCH] configure: replace $(realpath emacs) with $(cd emacs && pwd -P) Tomi Ollila
@ 2020-10-21 10:15 ` David Bremner
  0 siblings, 0 replies; 2+ messages in thread
From: David Bremner @ 2020-10-21 10:15 UTC (permalink / raw)
  To: Tomi Ollila, notmuch; +Cc: tomi.ollila

Tomi Ollila <tomi.ollila@iki.fi> writes:

> For portability; the realpath command (e.g. from GNU coreutils)
> is not so common outside Linux systems.
>
> The "$(cd emacs && pwd -P)" replaces that realpath(1) execution
> suitably in this context (using just bash(1) builtins).

Applied to master. It seems not to make things worse, although my
testing of the OOT build was hampered by the failure of the new python
bindings to build OOT [1].


[1]: id:87h7qnubsw.fsf@tethera.net

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-10-21 10:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-20  6:57 [PATCH] configure: replace $(realpath emacs) with $(cd emacs && pwd -P) Tomi Ollila
2020-10-21 10:15 ` David Bremner

unofficial mirror of notmuch@notmuchmail.org

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/notmuch/0 notmuch/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 notmuch notmuch/ https://yhetil.org/notmuch \
		notmuch@notmuchmail.org
	public-inbox-index notmuch

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.yhetil.org/yhetil.mail.notmuch.general
	nntp://news.gmane.io/gmane.mail.notmuch.general


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git