unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] lib: fix commented out NOTMUCH_DEPRECATED()
@ 2021-10-13 14:03 Jani Nikula
  2021-10-23 11:38 ` David Bremner
  0 siblings, 1 reply; 2+ messages in thread
From: Jani Nikula @ 2021-10-13 14:03 UTC (permalink / raw)
  To: notmuch; +Cc: jani

Remove the comment markers from the placeholder NOTMUCH_DEPRECATED(),
added in commit e5f3c3ed5024 ("lib: add stub for
notmuch_database_open_with_config").

---

This does lead to deprecation warnings now.
---
 lib/notmuch.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/notmuch.h b/lib/notmuch.h
index 546643e80cbb..b2227daef6ad 100644
--- a/lib/notmuch.h
+++ b/lib/notmuch.h
@@ -323,7 +323,7 @@ typedef enum {
  * config_path="" and error_message=NULL
  * @deprecated Deprecated as of libnotmuch 5.4 (notmuch 0.32)
  */
-/* NOTMUCH_DEPRECATED(5, 4) */
+NOTMUCH_DEPRECATED(5, 4)
 notmuch_status_t
 notmuch_database_open (const char *path,
 		       notmuch_database_mode_t mode,
@@ -335,7 +335,7 @@ notmuch_database_open (const char *path,
  * @deprecated Deprecated as of libnotmuch 5.4 (notmuch 0.32)
  *
  */
-/* NOTMUCH_DEPRECATED(5, 4) */
+NOTMUCH_DEPRECATED(5, 4)
 notmuch_status_t
 notmuch_database_open_verbose (const char *path,
 			       notmuch_database_mode_t mode,
-- 
2.30.2

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] lib: fix commented out NOTMUCH_DEPRECATED()
  2021-10-13 14:03 [PATCH] lib: fix commented out NOTMUCH_DEPRECATED() Jani Nikula
@ 2021-10-23 11:38 ` David Bremner
  0 siblings, 0 replies; 2+ messages in thread
From: David Bremner @ 2021-10-23 11:38 UTC (permalink / raw)
  To: Jani Nikula, notmuch

Jani Nikula <jani@nikula.org> writes:

> Remove the comment markers from the placeholder NOTMUCH_DEPRECATED(),
> added in commit e5f3c3ed5024 ("lib: add stub for
> notmuch_database_open_with_config").

Applied to master. There is, as a predicted, a few more deprecation
warnings we should deal with before the next major release.

d

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-10-23 11:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-13 14:03 [PATCH] lib: fix commented out NOTMUCH_DEPRECATED() Jani Nikula
2021-10-23 11:38 ` David Bremner

Code repositories for project(s) associated with this inbox:

	notmuch.git.git (no URL configured)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).