Test breakage on EPEL 8 with tree-outline-mode

Test breakage on EPEL 8 with tree-outline-mode

[Michael J Gruber]

Hi there,

the test suite started to fail on EPEL 8 with the new tree-outline-mode:
```
EMACS emacs/notmuch-tree.elc

In notmuch-tree-mode:
emacs/notmuch-tree.el:1088:9:Warning: reference to free variable
    `notmuch-tree-outline-enabled'

In notmuch-tree-outline--set-visibility:
emacs/notmuch-tree.el:1322:14:Warning: reference to free variable
    `notmuch-tree-outline-mode'
emacs/notmuch-tree.el:1415:20:Error: Wrong number of arguments: (2 . 2), 4
make: *** [emacs/Makefile.local:87: emacs/notmuch-tree.elc] Error 1
```
Does the implementation require a specific emacs version?
EPEL 8 has emacs 26.1.

I am not going to update official notmuch packages for EPEL 8 anyways,
but others might care about older emacs. (I do provide notmuch-git
test packages for EPEL 8 so far.)

Cheers
Michael

[PATCH] emacs/tree: use two argument form of setq-local

[David Bremner]

Apparently the macro setq-local only takes two arguments in Emacs 26.1
---
 emacs/notmuch-tree.el | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el
index 14775d59..b58fa6a6 100644
--- a/emacs/notmuch-tree.el
+++ b/emacs/notmuch-tree.el
@@ -1451,11 +1451,11 @@ notmuch-tree buffers, just set
   (unless (derived-mode-p 'notmuch-tree-mode)
     (user-error "notmuch-tree-outline-mode is only meaningful for notmuch trees!"))
   (if notmuch-tree-outline-mode
-      (progn (setq-local outline-regexp "^[^\n]+"
-			 outline-level #'notmuch-tree-outline--level)
+      (progn (setq-local outline-regexp "^[^\n]+")
+	     (setq-local outline-level #'notmuch-tree-outline--level)
 	     (notmuch-tree-outline--set-visibility))
-    (setq-local outline-regexp (default-value 'outline-regexp)
-		outline-level (default-value 'outline-level))))
+    (setq-local outline-regexp (default-value 'outline-regexp))
+    (setq-local	outline-level (default-value 'outline-level))))
 
 ;;; _
 
-- 
2.39.1

Re: [PATCH] emacs/tree: use two argument form of setq-local

[Michael J Gruber]

Am Di., 21. Feb. 2023 um 12:49 Uhr schrieb David Bremner <david@tethera.net>:
>
> Apparently the macro setq-local only takes two arguments in Emacs 26.1
> ---
>  emacs/notmuch-tree.el | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el
> index 14775d59..b58fa6a6 100644
> --- a/emacs/notmuch-tree.el
> +++ b/emacs/notmuch-tree.el
> @@ -1451,11 +1451,11 @@ notmuch-tree buffers, just set
>    (unless (derived-mode-p 'notmuch-tree-mode)
>      (user-error "notmuch-tree-outline-mode is only meaningful for notmuch trees!"))
>    (if notmuch-tree-outline-mode
> -      (progn (setq-local outline-regexp "^[^\n]+"
> -                        outline-level #'notmuch-tree-outline--level)
> +      (progn (setq-local outline-regexp "^[^\n]+")
> +            (setq-local outline-level #'notmuch-tree-outline--level)
>              (notmuch-tree-outline--set-visibility))
> -    (setq-local outline-regexp (default-value 'outline-regexp)
> -               outline-level (default-value 'outline-level))))
> +    (setq-local outline-regexp (default-value 'outline-regexp))
> +    (setq-local        outline-level (default-value 'outline-level))))
>

Thanks, notmuch.git master plus this patch builds happily again on
EPEL 8 (and 9, and ...).

Michael

Re: [PATCH] emacs/tree: use two argument form of setq-local

[David Bremner]

David Bremner <david@tethera.net> writes:

> Apparently the macro setq-local only takes two arguments in Emacs 26.1
> ---
>  emacs/notmuch-tree.el | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el
> index 14775d59..b58fa6a6 100644
> --- a/emacs/notmuch-tree.el
> +++ b/emacs/notmuch-tree.el
> @@ -1451,11 +1451,11 @@ notmuch-tree buffers, just set
>    (unless (derived-mode-p 'notmuch-tree-mode)
>      (user-error "notmuch-tree-outline-mode is only meaningful for notmuch trees!"))
>    (if notmuch-tree-outline-mode
> -      (progn (setq-local outline-regexp "^[^\n]+"
> -			 outline-level #'notmuch-tree-outline--level)
> +      (progn (setq-local outline-regexp "^[^\n]+")
> +	     (setq-local outline-level #'notmuch-tree-outline--level)
>  	     (notmuch-tree-outline--set-visibility))
> -    (setq-local outline-regexp (default-value 'outline-regexp)
> -		outline-level (default-value 'outline-level))))
> +    (setq-local outline-regexp (default-value 'outline-regexp))
> +    (setq-local	outline-level (default-value 'outline-level))))

Applied to master.

d