unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH v2] Add functions notmuch-show-get-(bcc, cc, date, from, subject, to).
       [not found] <id:1265942072-30247-3-git-send-email-david@tethera.net>
@ 2010-02-12  2:44 ` david
  2010-02-20 20:19   ` Carl Worth
  0 siblings, 1 reply; 2+ messages in thread
From: david @ 2010-02-12  2:44 UTC (permalink / raw)
  To: notmuch; +Cc: David Bremner

From: David Bremner <bremner@unb.ca>

Return the corresponding header field for the current message as a
string.  These are thin wrappers around notmuch-show-get-header, which
means they each cause a full parse of the RFC822 header. The main idea
is to fix an api.
---
Sorry, resending with fixed commit message.

 notmuch.el |   32 ++++++++++++++++++++++++++++++++
 1 files changed, 32 insertions(+), 0 deletions(-)

diff --git a/notmuch.el b/notmuch.el
index c96fd94..d2a3b1b 100644
--- a/notmuch.el
+++ b/notmuch.el
@@ -225,6 +225,38 @@ Unlike builtin `previous-line' this version accepts no arguments."
     (re-search-forward notmuch-show-tags-regexp)
     (split-string (buffer-substring (match-beginning 1) (match-end 1)))))
 
+(defun notmuch-show-get-bcc ()
+  "Return To address of current message"
+  (notmuch-show-get-header-field 'bcc))
+
+(defun notmuch-show-get-cc ()
+  "Return To address of current message"
+  (notmuch-show-get-header-field 'cc))
+
+(defun notmuch-show-get-date ()
+  "Return To address of current message"
+  (notmuch-show-get-header-field 'date))
+
+(defun notmuch-show-get-from ()
+  "Return From address of current message"
+  (notmuch-show-get-header-field 'from))
+
+(defun notmuch-show-get-subject ()
+  "Return subject of current message"
+  (notmuch-show-get-header-field 'subject))
+
+(defun notmuch-show-get-to ()
+  "Return To address of current message"
+  (notmuch-show-get-header-field 'to))
+
+(defun notmuch-show-get-header-field (name) 
+  "Retrieve the header field NAME from the current message.
+NAME should be a symbol, in lower case, as returned by 
+mail-header-extract-no-properties" 
+  (let* ((result (assoc name (notmuch-show-get-header)))
+	 (val (and result (cdr result))))
+    val))
+
 (defun notmuch-show-get-header ()
   "Retrieve and parse the header from the current message. Returns an alist with of (header . value) 
 where header is a symbol and value is a string.  The summary from notmuch-show is returned as the 
-- 
1.6.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] Add functions notmuch-show-get-(bcc, cc, date, from, subject, to).
  2010-02-12  2:44 ` [PATCH v2] Add functions notmuch-show-get-(bcc, cc, date, from, subject, to) david
@ 2010-02-20 20:19   ` Carl Worth
  0 siblings, 0 replies; 2+ messages in thread
From: Carl Worth @ 2010-02-20 20:19 UTC (permalink / raw)
  To: david, notmuch; +Cc: David Bremner

[-- Attachment #1: Type: text/plain, Size: 1065 bytes --]

On Thu, 11 Feb 2010 22:44:10 -0400, david@tethera.net wrote:
> Return the corresponding header field for the current message as a
> string.  These are thin wrappers around notmuch-show-get-header, which
> means they each cause a full parse of the RFC822 header. The main idea
> is to fix an api.

OK. You at least acknowledge the only misgiving I had about this
patch. (And frankly, my own emacs lisp code probably has much worse
performance bugs.) So I'm not going to worry about that for now.

> Sorry, resending with fixed commit message.

Much appreciated.

> +(defun notmuch-show-get-bcc ()
> +  "Return To address of current message"
> +  (notmuch-show-get-header-field 'bcc))
> +
> +(defun notmuch-show-get-cc ()
> +  "Return To address of current message"
> +  (notmuch-show-get-header-field 'cc))
> +
> +(defun notmuch-show-get-date ()
> +  "Return To address of current message"
> +  (notmuch-show-get-header-field 'date))

I fixed the obviously copied documentation strings above, deleted the
trailing whitespace, and applied this patch.

Thanks!

-Carl

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-02-20 20:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <id:1265942072-30247-3-git-send-email-david@tethera.net>
2010-02-12  2:44 ` [PATCH v2] Add functions notmuch-show-get-(bcc, cc, date, from, subject, to) david
2010-02-20 20:19   ` Carl Worth

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).