unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] fix checking whether header is member of message-hidden-headers
@ 2011-08-22 11:59 Tomi Ollila
  2011-08-25 12:11 ` David Bremner
  0 siblings, 1 reply; 2+ messages in thread
From: Tomi Ollila @ 2011-08-22 11:59 UTC (permalink / raw)
  To: notmuch


Emacs lisp function 'member' takes element and list as an
argument. I.e. the second argument is list, not symbol
referencing the list.
On emacs 23.x the member call always returned nil (thus buggy),
on emacs 22.x the call failed, making it unusable.
---
 emacs/notmuch-mua.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
index 274c5da..8824b08 100644
--- a/emacs/notmuch-mua.el
+++ b/emacs/notmuch-mua.el
@@ -65,7 +65,7 @@ list."
 (defun notmuch-mua-add-more-hidden-headers ()
   "Add some headers to the list that are hidden by default."
   (mapc (lambda (header)
-	  (when (not (member header 'message-hidden-headers))
+	  (when (not (member header message-hidden-headers))
 	    (push header message-hidden-headers)))
 	notmuch-mua-hidden-headers))
 
-- 
1.5.6.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] fix checking whether header is member of message-hidden-headers
  2011-08-22 11:59 [PATCH] fix checking whether header is member of message-hidden-headers Tomi Ollila
@ 2011-08-25 12:11 ` David Bremner
  0 siblings, 0 replies; 2+ messages in thread
From: David Bremner @ 2011-08-25 12:11 UTC (permalink / raw)
  To: Tomi Ollila, notmuch

On Mon, 22 Aug 2011 14:59:02 +0300, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> 
> Emacs lisp function 'member' takes element and list as an
> argument. I.e. the second argument is list, not symbol
> referencing the list.
> On emacs 23.x the member call always returned nil (thus buggy),
> on emacs 22.x the call failed, making it unusable.

Pushed.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-08-25 12:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-22 11:59 [PATCH] fix checking whether header is member of message-hidden-headers Tomi Ollila
2011-08-25 12:11 ` David Bremner

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).