From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] test/emacs: revert invalid-from test to pre-86f89385 behaviour
Date: Mon, 20 May 2019 11:10:49 -0400 [thread overview]
Message-ID: <87blzxb1qe.fsf@fifthhorseman.net> (raw)
In-Reply-To: <20190512024559.17612-1-david@tethera.net>
[-- Attachment #1: Type: text/plain, Size: 813 bytes --]
On Sat 2019-05-11 20:45:59 -0600, David Bremner wrote:
> To the best of my understanding, this original behaviour was what
> Carl's homebrew parser produced. With commit 86f89385 Austin switched
> to using GMime (2.6). This produced arguably worse results, but since
> the input was bad, we could live with it. Now with GMime 3.0 we are
> getting the original results again, and there is no reason to consider
> this test broken.
this works for me. I reviewed this earlier and tried to understand why
one ugly representation of invalid data was any worse than the other
ugly representation of invalid data. :P
It'd be great if someone wants to propose a principled way to handle
this invalid input, but just keeping the "broken" test around isn't a
good way to track that problem.
Please merge!
--dkg
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2019-05-20 17:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-12 2:45 [PATCH] test/emacs: revert invalid-from test to pre-86f89385 behaviour David Bremner
2019-05-12 10:35 ` Tomi Ollila
2019-05-20 15:10 ` Daniel Kahn Gillmor [this message]
2019-05-20 19:36 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blzxb1qe.fsf@fifthhorseman.net \
--to=dkg@fifthhorseman.net \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).