From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 901176DE1444 for ; Mon, 20 May 2019 10:21:04 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.165 X-Spam-Level: X-Spam-Status: No, score=-0.165 tagged_above=-999 required=5 tests=[AWL=0.036, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZrZLLfDHanC8 for ; Mon, 20 May 2019 10:21:04 -0700 (PDT) Received: from che.mayfirst.org (che.mayfirst.org [162.247.75.118]) by arlo.cworth.org (Postfix) with ESMTPS id B31A76DE143D for ; Mon, 20 May 2019 10:21:01 -0700 (PDT) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019; t=1558372860; h=from : to : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=NHEHXEKsmreIo97PFvi2VZsej2Vkr853Qje5/rw/gHU=; b=QcfNJcdyP8fXC1jsa0KdCM+HCFV4N78DqqnHKn8qpCdnYlXaFanxgUc1 eNmBaacSbZ1LLoxALpohfx+Dp+vDBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019rsa; t=1558372860; h=from : to : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=NHEHXEKsmreIo97PFvi2VZsej2Vkr853Qje5/rw/gHU=; b=BAe52Wwr2i4PX9u2oJKtpIEI2JuK66455vaAJuBk5lG5JJ+cixT/FCut DVL/bfuefLr4rzNHxyhZ9qJUu2TWVoq00HQBuC18iBSJZazZy2C/SJlfWp 2I8V+wVupbf9GW87N3DxEAa2yDmTrsR8aa2BmjMxWQfP18MkKd/+EVsAHF brQy/Z370R1tLNiBTHAhknkJ+dIM/LXESmaXXhCwSh8qtvKS8AGJmGjQxq RFRrVXHB/OM1KuHgQEZSfXQNPQmGxrHdUqDWoykHj3IVzCuwSTGl/sj2fA BrC7lCM5GgRh3V5nnBtGdfzjcfTzQQoxJzAtN5r4CmPh7/Dxlkzbaw== Received: from fifthhorseman.net (unknown [38.109.115.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by che.mayfirst.org (Postfix) with ESMTPSA id 13EDDF99E; Mon, 20 May 2019 13:20:59 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id 6516D201C0; Mon, 20 May 2019 11:10:50 -0400 (EDT) From: Daniel Kahn Gillmor To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH] test/emacs: revert invalid-from test to pre-86f89385 behaviour In-Reply-To: <20190512024559.17612-1-david@tethera.net> References: <20190512024559.17612-1-david@tethera.net> Autocrypt: addr=dkg@fifthhorseman.net; prefer-encrypt=mutual; keydata= mDMEXEK/AhYJKwYBBAHaRw8BAQdAr/gSROcn+6m8ijTN0DV9AahoHGafy52RRkhCZVwxhEe0K0Rh bmllbCBLYWhuIEdpbGxtb3IgPGRrZ0BmaWZ0aGhvcnNlbWFuLm5ldD6ImQQTFggAQQIbAQUJA8Jn AAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBMS8Lds4zOlkhevpwvIGkReQOOXGBQJcQsbzAhkB AAoJEPIGkReQOOXG4fkBAO1joRxqAZY57PjdzGieXLpluk9RkWa3ufkt3YUVEpH/AP9c+pgIxtyW +FwMQRjlqljuj8amdN4zuEqaCy4hhz/1DbgzBFxCv4sWCSsGAQQB2kcPAQEHQERSZxSPmgtdw6nN u7uxY7bzb9TnPrGAOp9kClBLRwGfiPUEGBYIACYWIQTEvC3bOMzpZIXr6cLyBpEXkDjlxgUCXEK/ iwIbAgUJAeEzgACBCRDyBpEXkDjlxnYgBBkWCAAdFiEEyQ5tNiAKG5IqFQnndhgZZSmuX/gFAlxC v4sACgkQdhgZZSmuX/iVWgD/fCU4ONzgy8w8UCHGmrmIZfDvdhg512NIBfx+Mz9ls5kA/Rq97vz4 z48MFuBdCuu0W/fVqVjnY7LN5n+CQJwGC0MIA7QA/RyY7Sz2gFIOcrns0RpoHr+3WI+won3xCD8+ sVXSHZvCAP98HCjDnw/b0lGuCR7coTXKLIM44/LFWgXAdZjm1wjODbg4BFxCv50SCisGAQQBl1UB BQEBB0BG4iXnHX/fs35NWKMWQTQoRI7oiAUt0wJHFFJbomxXbAMBCAeIfgQYFggAJhYhBMS8Lds4 zOlkhevpwvIGkReQOOXGBQJcQr+dAhsMBQkB4TOAAAoJEPIGkReQOOXGe/cBAPlek5d9xzcXUn/D kY6jKmxe26CTws3ZkbK6Aa5Ey/qKAP0VuPQSCRxA7RKfcB/XrEphfUFkraL06Xn/xGwJ+D0hCw== Date: Mon, 20 May 2019 11:10:49 -0400 Message-ID: <87blzxb1qe.fsf@fifthhorseman.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 May 2019 17:21:04 -0000 --=-=-= Content-Type: text/plain On Sat 2019-05-11 20:45:59 -0600, David Bremner wrote: > To the best of my understanding, this original behaviour was what > Carl's homebrew parser produced. With commit 86f89385 Austin switched > to using GMime (2.6). This produced arguably worse results, but since > the input was bad, we could live with it. Now with GMime 3.0 we are > getting the original results again, and there is no reason to consider > this test broken. this works for me. I reviewed this earlier and tried to understand why one ugly representation of invalid data was any worse than the other ugly representation of invalid data. :P It'd be great if someone wants to propose a principled way to handle this invalid input, but just keeping the "broken" test around isn't a good way to track that problem. Please merge! --dkg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQTJDm02IAobkioVCed2GBllKa5f+AUCXOLDeQAKCRB2GBllKa5f +FwnAQCdAMwrm/TKJUJKhCnOoV3AAeHHA9LB7rfD96/Yu/IciwEA9oBdm624DzxD HZlmgILKiivbq+Li63SM4uoe1UP/cAw= =PVbu -----END PGP SIGNATURE----- --=-=-=--