* [PATCH] test: add a known broken test for S/MIME decryption
@ 2019-11-18 1:58 David Bremner
2019-12-09 20:27 ` Daniel Kahn Gillmor
2019-12-14 11:39 ` David Bremner
0 siblings, 2 replies; 3+ messages in thread
From: David Bremner @ 2019-11-18 1:58 UTC (permalink / raw)
To: notmuch
This should serve to clarify this feature is not implimented in
notmuch yet.
---
test/T355-smime.sh | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/test/T355-smime.sh b/test/T355-smime.sh
index 336da917..11a4d6cd 100755
--- a/test/T355-smime.sh
+++ b/test/T355-smime.sh
@@ -94,4 +94,13 @@ Verification successful
EOF
test_expect_equal_file EXPECTED OUTPUT
+test_begin_subtest "Decryption (notmuch CLI)"
+test_subtest_known_broken
+notmuch show --decrypt=true subject:"test encrypted message 001" |\
+ grep "^This is a" > OUTPUT
+cat <<EOF > EXPECTED
+This is a test encrypted message.
+EOF
+test_expect_equal_file EXPECTED OUTPUT
+
test_done
--
2.24.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] test: add a known broken test for S/MIME decryption
2019-11-18 1:58 [PATCH] test: add a known broken test for S/MIME decryption David Bremner
@ 2019-12-09 20:27 ` Daniel Kahn Gillmor
2019-12-14 11:39 ` David Bremner
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Kahn Gillmor @ 2019-12-09 20:27 UTC (permalink / raw)
To: David Bremner, notmuch
[-- Attachment #1: Type: text/plain, Size: 1274 bytes --]
On Sun 2019-11-17 21:58:12 -0400, David Bremner wrote:
> This should serve to clarify this feature is not implimented in
> notmuch yet.
> ---
> test/T355-smime.sh | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/test/T355-smime.sh b/test/T355-smime.sh
> index 336da917..11a4d6cd 100755
> --- a/test/T355-smime.sh
> +++ b/test/T355-smime.sh
> @@ -94,4 +94,13 @@ Verification successful
> EOF
> test_expect_equal_file EXPECTED OUTPUT
>
> +test_begin_subtest "Decryption (notmuch CLI)"
> +test_subtest_known_broken
> +notmuch show --decrypt=true subject:"test encrypted message 001" |\
> + grep "^This is a" > OUTPUT
> +cat <<EOF > EXPECTED
> +This is a test encrypted message.
> +EOF
> +test_expect_equal_file EXPECTED OUTPUT
> +
> test_done
This looks good to me. I suspect that when we get full PKCS#7
decryption support, we'll want to use keys and certificates slightly
more sophisticated than the ones in this change (e.g. using the keys and
certs from https://www.ietf.org/id/draft-dkg-lamps-samples-01.html), but
the proposed patch here is a good placeholder that documents the current
state of play. And we can always update the test later as the new
functionality comes in.
Please merge!
--dkg
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] test: add a known broken test for S/MIME decryption
2019-11-18 1:58 [PATCH] test: add a known broken test for S/MIME decryption David Bremner
2019-12-09 20:27 ` Daniel Kahn Gillmor
@ 2019-12-14 11:39 ` David Bremner
1 sibling, 0 replies; 3+ messages in thread
From: David Bremner @ 2019-12-14 11:39 UTC (permalink / raw)
To: notmuch
David Bremner <david@tethera.net> writes:
> This should serve to clarify this feature is not implimented in
> notmuch yet.
Applied to master
d
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-14 11:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-18 1:58 [PATCH] test: add a known broken test for S/MIME decryption David Bremner
2019-12-09 20:27 ` Daniel Kahn Gillmor
2019-12-14 11:39 ` David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).