From: Pieter Praet <pieter@praet.org>
To: Aaron Ecay <aaronecay@gmail.com>, David Edmondson <dme@dme.org>,
Jameson Graef Rollins <jrollins@finestructure.net>
Cc: Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH] v2 emacs: colorize buttonized 'id:' links depending on the target message's state
Date: Wed, 18 Jan 2012 11:08:54 +0100 [thread overview]
Message-ID: <87aa5l8gqx.fsf@praet.org> (raw)
In-Reply-To: <m2sjjfb9xx.fsf@gmail.com>
On Mon, 16 Jan 2012 16:43:06 -0500, Aaron Ecay <aaronecay@gmail.com> wrote:
> On Mon, 16 Jan 2012 17:57:33 +0100, Pieter Praet <pieter@praet.org> wrote:
> > * emacs/notmuch-show.el (notmuch-show-buttonized-link-colors):
> > new defcustom, allows toggling colorization of buttonized links.
> >
> > * emacs/notmuch-show.el (notmuch-show-buttonized-link-present),
> > * emacs/notmuch-show.el (notmuch-show-buttonized-link-present-and-unread),
> > * emacs/notmuch-show.el (notmuch-show-buttonized-link-missing):
> > new faces for buttonized id: links.
> >
> > * emacs/notmuch-show.el (notmuch-show-found-target-p): add optional arg
> > VERIFY-UNREAD which causes results to be filtered by "tag:unread".
> >
> > * emacs/notmuch-show.el (notmuch-show-buttonize-links): use different
> > face property depending on the result of `notmuch-show-found-target-p',
> > causing buttons to available, available-and-unread and missing messages
> > to be displayed in a different color.
>
> I really like the idea behind this patch, but it has the very small
> problem that it colorizes too much. So in reading this thread, there
> are things like “id:’s” and “id:?” that get colored the missing-message
> color (a very angry red, by default). Though this isn’t likely to be a
> very frequent problem with email messages that are not on this listserv
> :), it would be nice to fix it. [...]
Excellent suggestion!
Amended patch follows.
> [...] Maybe you could change the regex that
> matches id:’s to require a little more structure – an at-sign, perhaps.
> Or even requiring more than (say) 5 non-space characters after the
> message id would cut down sharply on the false positive rate.
>
Not sure how that would pan out. It's fairly common behaviour to put
one or more spaces after a inline Message-Id, so I don't think such a
limitation would be warmly recepted.
> --
> Aaron Ecay
Peace
--
Pieter
next prev parent reply other threads:[~2012-01-18 10:10 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-23 4:59 [PATCH v2] emacs: call notmuch-show instead of notmuch-search in buttonised id: links Jameson Graef Rollins
2011-12-23 7:48 ` David Edmondson
2011-12-23 10:10 ` Xavier Maillard
2011-12-23 10:25 ` David Edmondson
2011-12-24 21:51 ` David Bremner
2012-01-12 17:20 ` Pieter Praet
2012-01-12 17:23 ` [PATCH 1/3] emacs: s/buttonise/buttonize/g Pieter Praet
2012-01-12 17:23 ` [PATCH 2/3] emacs: `notmuch-show-buttonize-links' only `notmuch-show's a message if it exists Pieter Praet
2012-01-16 11:43 ` David Edmondson
2012-01-16 16:49 ` Pieter Praet
2012-01-16 16:51 ` [PATCH v2] " Pieter Praet
2012-01-16 17:06 ` David Edmondson
2012-01-12 17:23 ` [PATCH 3/3] emacs: colorize buttonized 'id:' links depending on the target message's state Pieter Praet
2012-01-16 11:45 ` David Edmondson
2012-01-16 16:53 ` Pieter Praet
2012-01-16 16:54 ` Pieter Praet
2012-01-16 16:57 ` [PATCH] v2 " Pieter Praet
2012-01-16 17:07 ` David Edmondson
2012-01-16 21:43 ` Aaron Ecay
2012-01-18 10:08 ` Pieter Praet [this message]
2012-01-18 12:48 ` [PATCH 3/3 v3] " Pieter Praet
2012-01-20 19:15 ` [PATCH] v2 " Mark Anderson
2012-01-22 8:40 ` Pieter Praet
2012-01-22 8:54 ` [PATCH v4 1/3] emacs: s/buttonise/buttonize/g Pieter Praet
2012-01-22 8:54 ` [PATCH v4 2/3] emacs: `notmuch-show-buttonize-links' only `notmuch-show's a message if it exists Pieter Praet
2012-01-22 11:10 ` Mark Walters
2012-01-25 0:41 ` Pieter Praet
2014-05-07 15:22 ` David Edmondson
2017-03-05 11:52 ` David Bremner
2012-01-22 8:54 ` [PATCH v4 3/3] emacs: colorize buttonized 'id:' links depending on the target message's state Pieter Praet
2012-01-16 11:38 ` [PATCH 1/3] emacs: s/buttonise/buttonize/g David Edmondson
2012-01-25 11:16 ` David Bremner
2012-01-26 13:00 ` Pieter Praet
2012-01-26 14:34 ` Tomi Ollila
2017-03-05 11:51 ` [PATCH v2] emacs: call notmuch-show instead of notmuch-search in buttonised id: links David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87aa5l8gqx.fsf@praet.org \
--to=pieter@praet.org \
--cc=aaronecay@gmail.com \
--cc=dme@dme.org \
--cc=jrollins@finestructure.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).