From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 531F6431FBD for ; Wed, 18 Jan 2012 02:10:41 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pLGlHYDhVjox for ; Wed, 18 Jan 2012 02:10:40 -0800 (PST) Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 52D82431FAE for ; Wed, 18 Jan 2012 02:10:40 -0800 (PST) Received: by wgbdr13 with SMTP id dr13so2155027wgb.2 for ; Wed, 18 Jan 2012 02:10:39 -0800 (PST) Received: by 10.180.81.72 with SMTP id y8mr35421554wix.14.1326881439197; Wed, 18 Jan 2012 02:10:39 -0800 (PST) Received: from localhost ([109.131.97.13]) by mx.google.com with ESMTPS id gy6sm21588850wib.11.2012.01.18.02.10.37 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 18 Jan 2012 02:10:38 -0800 (PST) From: Pieter Praet To: Aaron Ecay , David Edmondson , Jameson Graef Rollins Subject: Re: [PATCH] v2 emacs: colorize buttonized 'id:' links depending on the target message's state In-Reply-To: References: <87hazva8qe.fsf@praet.org> <1326733053-25185-1-git-send-email-pieter@praet.org> User-Agent: Notmuch/0.11+86~g67f4140 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-unknown-linux-gnu) Date: Wed, 18 Jan 2012 11:08:54 +0100 Message-ID: <87aa5l8gqx.fsf@praet.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: Notmuch Mail X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jan 2012 10:10:41 -0000 On Mon, 16 Jan 2012 16:43:06 -0500, Aaron Ecay wrote: > On Mon, 16 Jan 2012 17:57:33 +0100, Pieter Praet wrote: > > * emacs/notmuch-show.el (notmuch-show-buttonized-link-colors): > > new defcustom, allows toggling colorization of buttonized links. > >=20 > > * emacs/notmuch-show.el (notmuch-show-buttonized-link-present), > > * emacs/notmuch-show.el (notmuch-show-buttonized-link-present-and-unrea= d), > > * emacs/notmuch-show.el (notmuch-show-buttonized-link-missing): > > new faces for buttonized id: links. > >=20 > > * emacs/notmuch-show.el (notmuch-show-found-target-p): add optional arg > > VERIFY-UNREAD which causes results to be filtered by "tag:unread". > >=20 > > * emacs/notmuch-show.el (notmuch-show-buttonize-links): use different > > face property depending on the result of `notmuch-show-found-target-p= ', > > causing buttons to available, available-and-unread and missing messag= es > > to be displayed in a different color. >=20 > I really like the idea behind this patch, but it has the very small > problem that it colorizes too much. So in reading this thread, there > are things like =E2=80=9Cid:=E2=80=99s=E2=80=9D and =E2=80=9Cid:?=E2=80= =9D that get colored the missing-message > color (a very angry red, by default). Though this isn=E2=80=99t likely t= o be a > very frequent problem with email messages that are not on this listserv > :), it would be nice to fix it. [...] Excellent suggestion! Amended patch follows. > [...] Maybe you could change the regex that > matches id:=E2=80=99s to require a little more structure =E2=80=93 an at-= sign, perhaps. > Or even requiring more than (say) 5 non-space characters after the > message id would cut down sharply on the false positive rate. >=20 Not sure how that would pan out. It's fairly common behaviour to put one or more spaces after a inline Message-Id, so I don't think such a limitation would be warmly recepted. > --=20 > Aaron Ecay Peace --=20 Pieter