Re: [PATCH 1/4] test: add known broken test for uncaught DatabaseModifiedError

[David Bremner <david@tethera.net>]

Jani Nikula <jani@nikula.org> writes:
>> +
>> +add_email_corpus
>
> Is the whole corpus necessary? Just add a single message?

Good point, that's actually leftover from a previous failed attempt.

>> +test_begin_subtest "catching DatabaseModifiedError in _notmuch_message_ensure_metadata"
>> +test_subtest_known_broken
>> +test_C ${MAIL_DIR} <<'EOF'
>
> I'm not entirely thrilled by the whole test_C thing, but I guess I've
> lost that battle... :/
>
>> +#include <unistd.h>
>> +#include <stdlib.h>
>> +#include <notmuch-test.h>
>> +#include <talloc.h>
>> +int
>> +main (int argc, char **argv)
>> +{
>> +    pid_t child;
>
> Leftover variable?

correct.

> How about add_message with a specific message-id, and using that here? I
> think we rely too much on the test corpus and hard-code stuff from there
> too much.

Good idea.