From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david@tethera.net>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 0DC276DE1F2D
 for <notmuch@notmuchmail.org>; Sat, 25 Feb 2017 12:08:45 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: -0.005
X-Spam-Level: 
X-Spam-Status: No, score=-0.005 tagged_above=-999 required=5 tests=[AWL=0.006, 
 SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id ywbh68RfRlVl for <notmuch@notmuchmail.org>;
 Sat, 25 Feb 2017 12:08:44 -0800 (PST)
Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
 by arlo.cworth.org (Postfix) with ESMTPS id 6CBC36DE1F22
 for <notmuch@notmuchmail.org>; Sat, 25 Feb 2017 12:08:44 -0800 (PST)
Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2)
 (envelope-from <david@tethera.net>)
 id 1chidR-0006aD-Gx; Sat, 25 Feb 2017 15:08:05 -0500
Received: (nullmailer pid 23447 invoked by uid 1000);
 Sat, 25 Feb 2017 20:08:42 -0000
From: David Bremner <david@tethera.net>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org, eg@gaute.vetsj.com
Subject: Re: [PATCH 1/4] test: add known broken test for uncaught
 DatabaseModifiedError
In-Reply-To: <87k28e6r72.fsf@nikula.org>
References: <20170225034513.19427-1-david@tethera.net>
 <20170225034513.19427-2-david@tethera.net> <87k28e6r72.fsf@nikula.org>
Date: Sat, 25 Feb 2017 16:08:42 -0400
Message-ID: <878tou119x.fsf@tethera.net>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sat, 25 Feb 2017 20:08:45 -0000

Jani Nikula <jani@nikula.org> writes:
>> +
>> +add_email_corpus
>
> Is the whole corpus necessary? Just add a single message?

Good point, that's actually leftover from a previous failed attempt.

>> +test_begin_subtest "catching DatabaseModifiedError in _notmuch_message_ensure_metadata"
>> +test_subtest_known_broken
>> +test_C ${MAIL_DIR} <<'EOF'
>
> I'm not entirely thrilled by the whole test_C thing, but I guess I've
> lost that battle... :/
>
>> +#include <unistd.h>
>> +#include <stdlib.h>
>> +#include <notmuch-test.h>
>> +#include <talloc.h>
>> +int
>> +main (int argc, char **argv)
>> +{
>> +    pid_t child;
>
> Leftover variable?

correct.

> How about add_message with a specific message-id, and using that here? I
> think we rely too much on the test corpus and hard-code stuff from there
> too much.

Good idea.