Re: [PATCH 2/2] cli/dump: don't include tags when not asked for

[David Bremner <david@tethera.net>]

David Bremner <david@tethera.net> writes:

> Add in the analogous test for tags that is given for properties a few
> lines below.
> ---
>  notmuch-dump.c                | 3 ++-
>  test/T610-message-property.sh | 1 -
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/notmuch-dump.c b/notmuch-dump.c
> index e451ac0c..5cc3b2f6 100644
> --- a/notmuch-dump.c
> +++ b/notmuch-dump.c
> @@ -250,7 +250,8 @@ database_dump_file (notmuch_database_t *notmuch, gzFile output,
>  
>  	message = notmuch_messages_get (messages);
>  
> -	if (dump_tags_message (notmuch, message, output_format, output,
> +	if ((include & DUMP_INCLUDE_TAGS) &&
> +	    dump_tags_message (notmuch, message, output_format, output,
>  			       &buffer, &buffer_size))
>  	    return EXIT_FAILURE;

I'd like to include this two line patch in 0.24.2, along with Mark's fix
2d79d38a0. Any objections? Any other similar fixes that should be
included in 0.24.2?

d