From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id BF7CA6DE0314 for ; Tue, 23 May 2017 04:11:27 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.001 X-Spam-Level: X-Spam-Status: No, score=-0.001 tagged_above=-999 required=5 tests=[AWL=0.010, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VIW0nQk4u3D1 for ; Tue, 23 May 2017 04:11:26 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id B0FD56DE0191 for ; Tue, 23 May 2017 04:11:26 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2) (envelope-from ) id 1dD7ht-0006Xx-AO; Tue, 23 May 2017 07:10:29 -0400 Received: (nullmailer pid 27719 invoked by uid 1000); Tue, 23 May 2017 11:11:23 -0000 From: David Bremner To: notmuch@freelists.org, notmuch@notmuchmail.org Subject: Re: [PATCH 2/2] cli/dump: don't include tags when not asked for In-Reply-To: <20170508014423.20765-2-david@tethera.net> References: <87y3u8vjbo.fsf@tethera.net> <20170508014423.20765-1-david@tethera.net> <20170508014423.20765-2-david@tethera.net> Date: Tue, 23 May 2017 08:11:23 -0300 Message-ID: <878tlnn7z8.fsf@tethera.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 May 2017 11:11:27 -0000 David Bremner writes: > Add in the analogous test for tags that is given for properties a few > lines below. > --- > notmuch-dump.c | 3 ++- > test/T610-message-property.sh | 1 - > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/notmuch-dump.c b/notmuch-dump.c > index e451ac0c..5cc3b2f6 100644 > --- a/notmuch-dump.c > +++ b/notmuch-dump.c > @@ -250,7 +250,8 @@ database_dump_file (notmuch_database_t *notmuch, gzFile output, > > message = notmuch_messages_get (messages); > > - if (dump_tags_message (notmuch, message, output_format, output, > + if ((include & DUMP_INCLUDE_TAGS) && > + dump_tags_message (notmuch, message, output_format, output, > &buffer, &buffer_size)) > return EXIT_FAILURE; I'd like to include this two line patch in 0.24.2, along with Mark's fix 2d79d38a0. Any objections? Any other similar fixes that should be included in 0.24.2? d