Don't use GNU Parallel --version, use --minversion instead

Don't use GNU Parallel --version, use --minversion instead

[Ole Tange]

Commit:
https://git.notmuchmail.org/git?p=notmuch;a=commitdiff;h=f2b5ad28e2b7b512d66946af34dd4149d1506bf4

Using GNU Parallel this way is not supported, and you have already
experienced why. But what _is_ supported for your use is using:

    parallel --minversion 20201122

which prints the version number and returns true if the version is >=
20201122. It is specifically made for situations like this.

Replace 20201122 with the earliest version of GNU Parallel which has
all the features needed for running your tasks.

Also remember that you can use `parallel --embed`.

/Ole

[PATCH] test: use --minversion to detect GNU Parallel.

[David Bremner]

Based on a suggestion of Ole Tange [1].

[1]: id:CA+4vN7x6jp4HCiEybZ=5g+2X6Pa7etBFX3Bbd=UYty37gR6wEQ@mail.gmail.com
---
 test/notmuch-test | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/notmuch-test b/test/notmuch-test
index ce142f7c..eefdf091 100755
--- a/test/notmuch-test
+++ b/test/notmuch-test
@@ -51,7 +51,7 @@ RES=0
 # Run the tests
 if test -z "${NOTMUCH_TEST_SERIALIZE-}" && command -v parallel >/dev/null ; then
     test -t 1 && export COLORS_WITHOUT_TTY=t || :
-    if parallel --version 2>&1 | grep -q GNU ; then
+    if parallel --minversion 0 1>/dev/null 2>&1  ; then
         echo "INFO: running tests with GNU parallel"
         printf '%s\n' $TESTS | $TEST_TIMEOUT_CMD parallel || RES=$?
     else
-- 
2.30.2

Re: [PATCH] test: use --minversion to detect GNU Parallel.

[Tomi Ollila]

On Mon, Aug 02 2021, David Bremner wrote:

> Based on a suggestion of Ole Tange [1].
>
> [1]: id:CA+4vN7x6jp4HCiEybZ=5g+2X6Pa7etBFX3Bbd=UYty37gR6wEQ@mail.gmail.com
> ---
>  test/notmuch-test | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/notmuch-test b/test/notmuch-test
> index ce142f7c..eefdf091 100755
> --- a/test/notmuch-test
> +++ b/test/notmuch-test
> @@ -51,7 +51,7 @@ RES=0
>  # Run the tests
>  if test -z "${NOTMUCH_TEST_SERIALIZE-}" && command -v parallel >/dev/null ; then
>      test -t 1 && export COLORS_WITHOUT_TTY=t || :
> -    if parallel --version 2>&1 | grep -q GNU ; then
> +    if parallel --minversion 0 1>/dev/null 2>&1  ; then

fix the 2 spaces ;D

the 1 before >/dev/null is a bit confusing, fast reader reads parallel --minversion 0 1
as the arguments. so I'd suggest to drop the '1'.

Tomi


>          echo "INFO: running tests with GNU parallel"
>          printf '%s\n' $TESTS | $TEST_TIMEOUT_CMD parallel || RES=$?
>      else
> -- 
> 2.30.2
> _______________________________________________
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-leave@notmuchmail.org

Re: [PATCH] test: use --minversion to detect GNU Parallel.

[David Bremner]

David Bremner <david@tethera.net> writes:

> Based on a suggestion of Ole Tange [1].
>

amended per Tomi's suggestions, and applied.