* [PATCH] lib: fix clang compiler warning
@ 2014-01-17 16:21 Jani Nikula
2014-01-19 0:05 ` David Bremner
0 siblings, 1 reply; 2+ messages in thread
From: Jani Nikula @ 2014-01-17 16:21 UTC (permalink / raw)
To: notmuch
With some combination of clang and talloc, not using the return value
of talloc_steal() produces a warning. Ignore it, as talloc_steal() has
no failure modes per documentation.
---
lib/thread.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/thread.cc b/lib/thread.cc
index 4dcf705..8f53e12 100644
--- a/lib/thread.cc
+++ b/lib/thread.cc
@@ -524,7 +524,7 @@ _notmuch_thread_create (void *ctx,
_resolve_thread_relationships (thread);
/* Commit to returning thread. */
- talloc_steal (ctx, thread);
+ (void) talloc_steal (ctx, thread);
DONE:
talloc_free (local);
--
1.8.5.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] lib: fix clang compiler warning
2014-01-17 16:21 [PATCH] lib: fix clang compiler warning Jani Nikula
@ 2014-01-19 0:05 ` David Bremner
0 siblings, 0 replies; 2+ messages in thread
From: David Bremner @ 2014-01-19 0:05 UTC (permalink / raw)
To: Jani Nikula, notmuch
Jani Nikula <jani@nikula.org> writes:
> With some combination of clang and talloc, not using the return value
> of talloc_steal() produces a warning. Ignore it, as talloc_steal() has
> no failure modes per documentation.
pushed.
d
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-19 0:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-17 16:21 [PATCH] lib: fix clang compiler warning Jani Nikula
2014-01-19 0:05 ` David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).