* [PATCH] test: Simplify CLEAN list construction
@ 2014-02-25 19:18 Austin Clements
2014-02-25 19:30 ` Tomi Ollila
2014-02-26 1:05 ` David Bremner
0 siblings, 2 replies; 3+ messages in thread
From: Austin Clements @ 2014-02-25 19:18 UTC (permalink / raw)
To: notmuch
Construct as much of the CLEAN list from TEST_BINARIES as possible,
rather than duplicating this information by hand.
---
test/Makefile.local | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/test/Makefile.local b/test/Makefile.local
index 8870ca3..99324ba 100644
--- a/test/Makefile.local
+++ b/test/Makefile.local
@@ -50,11 +50,6 @@ test: all test-binaries
check: test
SRCS := $(SRCS) $(smtp_dummy_srcs)
-CLEAN := $(CLEAN) $(dir)/smtp-dummy $(dir)/smtp-dummy.o \
- $(dir)/symbol-test $(dir)/symbol-test.o \
- $(dir)/arg-test $(dir)/arg-test.o \
- $(dir)/hex-xcode $(dir)/hex-xcode.o \
+CLEAN += $(TEST_BINARIES) $(addsuffix .o,$(TEST_BINARIES)) \
$(dir)/database-test.o \
- $(dir)/random-corpus $(dir)/random-corpus.o \
- $(dir)/parse-time $(dir)/parse-time.o \
$(dir)/corpus.mail $(dir)/test-results $(dir)/tmp.*
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] test: Simplify CLEAN list construction
2014-02-25 19:18 [PATCH] test: Simplify CLEAN list construction Austin Clements
@ 2014-02-25 19:30 ` Tomi Ollila
2014-02-26 1:05 ` David Bremner
1 sibling, 0 replies; 3+ messages in thread
From: Tomi Ollila @ 2014-02-25 19:30 UTC (permalink / raw)
To: Austin Clements, notmuch
On Tue, Feb 25 2014, Austin Clements <amdragon@MIT.EDU> wrote:
> Construct as much of the CLEAN list from TEST_BINARIES as possible,
> rather than duplicating this information by hand.
> ---
LGTM. database-test.c is a "library"
Tomi
> test/Makefile.local | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/test/Makefile.local b/test/Makefile.local
> index 8870ca3..99324ba 100644
> --- a/test/Makefile.local
> +++ b/test/Makefile.local
> @@ -50,11 +50,6 @@ test: all test-binaries
> check: test
>
> SRCS := $(SRCS) $(smtp_dummy_srcs)
> -CLEAN := $(CLEAN) $(dir)/smtp-dummy $(dir)/smtp-dummy.o \
> - $(dir)/symbol-test $(dir)/symbol-test.o \
> - $(dir)/arg-test $(dir)/arg-test.o \
> - $(dir)/hex-xcode $(dir)/hex-xcode.o \
> +CLEAN += $(TEST_BINARIES) $(addsuffix .o,$(TEST_BINARIES)) \
> $(dir)/database-test.o \
> - $(dir)/random-corpus $(dir)/random-corpus.o \
> - $(dir)/parse-time $(dir)/parse-time.o \
> $(dir)/corpus.mail $(dir)/test-results $(dir)/tmp.*
> --
> 1.8.4.rc3
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] test: Simplify CLEAN list construction
2014-02-25 19:18 [PATCH] test: Simplify CLEAN list construction Austin Clements
2014-02-25 19:30 ` Tomi Ollila
@ 2014-02-26 1:05 ` David Bremner
1 sibling, 0 replies; 3+ messages in thread
From: David Bremner @ 2014-02-26 1:05 UTC (permalink / raw)
To: Austin Clements, notmuch
Austin Clements <amdragon@MIT.EDU> writes:
> Construct as much of the CLEAN list from TEST_BINARIES as possible,
> rather than duplicating this information by hand.
pushed,
d
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-26 1:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-25 19:18 [PATCH] test: Simplify CLEAN list construction Austin Clements
2014-02-25 19:30 ` Tomi Ollila
2014-02-26 1:05 ` David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).