[PATCH] test: Print the number of the test along with its name

[PATCH] test: Print the number of the test along with its name

[Austin Clements]

Previously, we stripped the "Tnnn-" part from the test name when
printing its description at the beginning of each test.  However, this
makes it difficult to find the source script for a test (e.g., when a
test fails).  Put this prefix back.
---
 test/test-lib.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/test-lib.sh b/test/test-lib.sh
index 78af170..9dad126 100644
--- a/test/test-lib.sh
+++ b/test/test-lib.sh
@@ -196,7 +196,7 @@ print_test_description ()
 {
 	test -z "$test_description_printed" || return 0
 	echo
-	echo $this_test_bare: "Testing ${test_description}"
+	echo $this_test: "Testing ${test_description}"
 	test_description_printed=1
 }
 if [ -z "$NOTMUCH_TEST_QUIET" ]
-- 
1.8.4.rc3

Re: [PATCH] test: Print the number of the test along with its name

[Tomi Ollila]

On Tue, Mar 04 2014, Austin Clements <amdragon@MIT.EDU> wrote:

> Previously, we stripped the "Tnnn-" part from the test name when
> printing its description at the beginning of each test.  However, this
> makes it difficult to find the source script for a test (e.g., when a
> test fails).  Put this prefix back.

LGTM.

Tomi


> ---
>  test/test-lib.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/test-lib.sh b/test/test-lib.sh
> index 78af170..9dad126 100644
> --- a/test/test-lib.sh
> +++ b/test/test-lib.sh
> @@ -196,7 +196,7 @@ print_test_description ()
>  {
>  	test -z "$test_description_printed" || return 0
>  	echo
> -	echo $this_test_bare: "Testing ${test_description}"
> +	echo $this_test: "Testing ${test_description}"
>  	test_description_printed=1
>  }
>  if [ -z "$NOTMUCH_TEST_QUIET" ]
> -- 
> 1.8.4.rc3
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] test: Print the number of the test along with its name

[Jani Nikula]

On Tue, 04 Mar 2014, Austin Clements <amdragon@MIT.EDU> wrote:
> Previously, we stripped the "Tnnn-" part from the test name when
> printing its description at the beginning of each test.  However, this
> makes it difficult to find the source script for a test (e.g., when a
> test fails).  Put this prefix back.

Yes, please!

Jani.


> ---
>  test/test-lib.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/test-lib.sh b/test/test-lib.sh
> index 78af170..9dad126 100644
> --- a/test/test-lib.sh
> +++ b/test/test-lib.sh
> @@ -196,7 +196,7 @@ print_test_description ()
>  {
>  	test -z "$test_description_printed" || return 0
>  	echo
> -	echo $this_test_bare: "Testing ${test_description}"
> +	echo $this_test: "Testing ${test_description}"
>  	test_description_printed=1
>  }
>  if [ -z "$NOTMUCH_TEST_QUIET" ]
> -- 
> 1.8.4.rc3
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] test: Print the number of the test along with its name

[David Bremner]

Austin Clements <amdragon@MIT.EDU> writes:

> Previously, we stripped the "Tnnn-" part from the test name when
> printing its description at the beginning of each test.  However, this
> makes it difficult to find the source script for a test (e.g., when a
> test fails).  Put this prefix back.

pushed,

d