test/T010-help-test.sh fails after ./configure --without-docs

test/T010-help-test.sh fails after ./configure --without-docs

[Daniel Kahn Gillmor]

[-- Attachment #1: Type: text/plain, Size: 1574 bytes --]

On a system where man and notmuch are both already installed, i tried to
./configure --without-docs to avoid the delays during development
associated with id:87r29wwgq2.fsf@fifthhorseman.net.

The configuration succeeds, but now these tests fail:

0 dkg@alice:~/src/notmuch/notmuch$ make check NOTMUCH_TESTS=T010-help-test.sh V=1
Missing sphinx or makeinfo, not building info pages
INFO: using 2 minute timeout for tests

T010-help-test: Testing online help
 PASS   notmuch --help
 PASS   notmuch help
 PASS   notmuch --version
 FAIL   notmuch --help tag (man pages not available)
	test_must_fail notmuch --help tag >/dev/null
 FAIL   notmuch help tag (man pages not available)
	test_must_fail notmuch help tag >/dev/null

Notmuch test suite complete.
3/5 tests passed.
2 tests failed.
make: *** [test/Makefile.local:75: test] Error 1
[1]+  Done                    gitk --all
2 dkg@alice:~/src/notmuch/notmuch$

It seems likely that they're "failing to fail" because the main system
i'm building on has both notmuch and man installed -- so maybe the
locally-built notmuch is successfully opening the manual pages from the
system instead of the development manpages.

I did a bit of digging to try to understand the issue, and noticed that
the comments about test_must_fail in test/test-lib.sh seem out of date
(they assume two arguments instead of one, and they refer to their
earlier provenance in git, rather than notmuch).  But i think the
problem isn't with test_must_fail itself, even though the function's
documentation appears to be out of date.

              --dkg

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

Re: test/T010-help-test.sh fails after ./configure --without-docs

[David Bremner]

Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:

> On a system where man and notmuch are both already installed, i tried to
> ./configure --without-docs to avoid the delays during development
> associated with id:87r29wwgq2.fsf@fifthhorseman.net.
>
> The configuration succeeds, but now these tests fail:
>
> 0 dkg@alice:~/src/notmuch/notmuch$ make check NOTMUCH_TESTS=T010-help-test.sh V=1
> Missing sphinx or makeinfo, not building info pages
> INFO: using 2 minute timeout for tests
>
> T010-help-test: Testing online help
>  PASS   notmuch --help
>  PASS   notmuch help
>  PASS   notmuch --version
>  FAIL   notmuch --help tag (man pages not available)
> 	test_must_fail notmuch --help tag >/dev/null
>  FAIL   notmuch help tag (man pages not available)
> 	test_must_fail notmuch help tag >/dev/null
>

Are you sure you ran "make clean" after reconfiguring? I had the same
result as you because doc/_build/man was lying around from a previous
build.

d

Re: test/T010-help-test.sh fails after ./configure --without-docs

[Daniel Kahn Gillmor]

[-- Attachment #1: Type: text/plain, Size: 1253 bytes --]

On Sun 2019-04-21 09:49:50 -0300, David Bremner wrote:
> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
>
>> On a system where man and notmuch are both already installed, i tried to
>> ./configure --without-docs to avoid the delays during development
>> associated with id:87r29wwgq2.fsf@fifthhorseman.net.
>>
>> The configuration succeeds, but now these tests fail:
>>
>> 0 dkg@alice:~/src/notmuch/notmuch$ make check NOTMUCH_TESTS=T010-help-test.sh V=1
>> Missing sphinx or makeinfo, not building info pages
>> INFO: using 2 minute timeout for tests
>>
>> T010-help-test: Testing online help
>>  PASS   notmuch --help
>>  PASS   notmuch help
>>  PASS   notmuch --version
>>  FAIL   notmuch --help tag (man pages not available)
>> 	test_must_fail notmuch --help tag >/dev/null
>>  FAIL   notmuch help tag (man pages not available)
>> 	test_must_fail notmuch help tag >/dev/null
>
> Are you sure you ran "make clean" after reconfiguring? I had the same
> result as you because doc/_build/man was lying around from a previous
> build.

Thanks, Bremner!  Turns out that was exactly what i was running into.
"make clean" and then rebuilding does indeed solve the problem for me.
this was a bug in my workflow, not a bug in notmuch itself.

     --dkg

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]