unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] emacs: fix docstring for `notmuch-search-line-faces'.
@ 2011-12-23 20:40 Dmitry Kurochkin
  2011-12-23 21:51 ` David Edmondson
  2011-12-24 21:53 ` David Bremner
  0 siblings, 2 replies; 3+ messages in thread
From: Dmitry Kurochkin @ 2011-12-23 20:40 UTC (permalink / raw)
  To: notmuch

Examples in documentation for `notmuch-search-line-faces' had an extra
quote, e.g.:

  '(\"unread\" . '(:foreground \"green\"))

Which resulted in values like:

  (\"unread\" quote (:foreground \"green\"))

And tons of "Invalid face reference: quote" errors in the messages
buffer.
---
 emacs/notmuch.el |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index 270f983..fde2377 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -646,9 +646,9 @@ This function advances the next thread when finished."
 Here is an example of how to color search results based on tags.
  (the following text would be placed in your ~/.emacs file):
 
- (setq notmuch-search-line-faces '((\"delete\" . '(:foreground \"red\"
-						   :background \"blue\"))
-                                   (\"unread\" . '(:foreground \"green\"))))
+ (setq notmuch-search-line-faces '((\"delete\" . (:foreground \"red\"
+						  :background \"blue\"))
+                                   (\"unread\" . (:foreground \"green\"))))
 
 The attributes defined for matching tags are merged, with later
 attributes overriding earlier. A message having both \"delete\"
-- 
1.7.7.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] emacs: fix docstring for `notmuch-search-line-faces'.
  2011-12-23 20:40 [PATCH] emacs: fix docstring for `notmuch-search-line-faces' Dmitry Kurochkin
@ 2011-12-23 21:51 ` David Edmondson
  2011-12-24 21:53 ` David Bremner
  1 sibling, 0 replies; 3+ messages in thread
From: David Edmondson @ 2011-12-23 21:51 UTC (permalink / raw)
  To: Dmitry Kurochkin, notmuch

[-- Attachment #1: Type: text/plain, Size: 25 bytes --]

Looks obviously correct.

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] emacs: fix docstring for `notmuch-search-line-faces'.
  2011-12-23 20:40 [PATCH] emacs: fix docstring for `notmuch-search-line-faces' Dmitry Kurochkin
  2011-12-23 21:51 ` David Edmondson
@ 2011-12-24 21:53 ` David Bremner
  1 sibling, 0 replies; 3+ messages in thread
From: David Bremner @ 2011-12-24 21:53 UTC (permalink / raw)
  To: Dmitry Kurochkin, notmuch

On Sat, 24 Dec 2011 00:40:34 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> Examples in documentation for `notmuch-search-line-faces' had an extra
> quote, e.g.:
> 
>   '(\"unread\" . '(:foreground \"green\"))
> 

Pushed. 

d

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-12-24 21:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-12-23 20:40 [PATCH] emacs: fix docstring for `notmuch-search-line-faces' Dmitry Kurochkin
2011-12-23 21:51 ` David Edmondson
2011-12-24 21:53 ` David Bremner

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).