[Raúl Benencia] Bug#789693: notmuch-emacs: notmuch-tree does not mark messages as read

[Raúl Benencia] Bug#789693: notmuch-emacs: notmuch-tree does not mark messages as read

[David Bremner]

[-- Attachment #1: Type: text/plain, Size: 211 bytes --]


Hi Mark;

This seems to be true for me also. Strange that I never noticed before.
Am I right in thinking that patch

   id:1433843467-32398-1-git-send-email-markwalters1009@gmail.com

is directed to fix this?


[-- Attachment #2: Type: message/rfc822, Size: 5725 bytes --]

From: "Raúl Benencia" <rul@kalgan.cc>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: Bug#789693: notmuch-emacs: notmuch-tree does not mark messages as read
Date: Tue, 23 Jun 2015 10:05:52 -0300
Message-ID: <20150623130552.402.91709.reportbug@trantor.kalgan.cc>

Package: notmuch-emacs
Version: 0.20.1-1
Severity: important
Tags: upstream

Hi,

Whenever I'm in notmuch-tree mode and move around between unread messages
(i.e. with "p" and "n"), I can see that messages are marked as read
(-unread is crossed out), but this tag changes are not reflected in notmuch
database. Consequently, I have to manually remove the "unread" tag.

Cheers,
Rul

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.0.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages notmuch-emacs depends on:
ii  emacs24         24.4+1-5
ii  emacsen-common  2.0.8
ii  notmuch         0.20.1-1

notmuch-emacs recommends no packages.

notmuch-emacs suggests no packages.

-- no debconf information

Re: [Raúl Benencia] Bug#789693: notmuch-emacs: notmuch-tree does not mark messages as read

[Mark Walters]

Hi

> This seems to be true for me also. Strange that I never noticed before.
> Am I right in thinking that patch
>
>    id:1433843467-32398-1-git-send-email-markwalters1009@gmail.com
>
> is directed to fix this?

Yes that is correct. What happened is that the tree code relied on the
message-pane (a show buffer) to mark the message read, but updated its
own display. After the unread handling changes the show buffer only marks a
message read if it is the active buffer (so its post-command hook gets
called), so it no longer removes the unread tag.

Best wishes

Mark

(PS this message shows the deficiencies in our emacs reply handling: it
doesn't include the rfc822 part!)

Re: [Raúl Benencia] Bug#789693: notmuch-emacs: notmuch-tree does not mark messages as read

[David Bremner]

David Bremner <david@tethera.net> writes:

> Hi Mark;
>
> This seems to be true for me also. Strange that I never noticed before.
> Am I right in thinking that patch
>
>    id:1433843467-32398-1-git-send-email-markwalters1009@gmail.com

This patch is included in release 0.20.2 (commit 5e37568). Marking this
fixed.

d