unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] test: add two emacs tests for show mode refresh
       [not found] <id:1306627784-3401-1-git-send-email-jrollins@finestructure.net>
@ 2011-10-09  3:21 ` Jameson Graef Rollins
  2011-10-09  3:26   ` Jameson Graef Rollins
  2011-10-09 11:31   ` David Bremner
  0 siblings, 2 replies; 3+ messages in thread
From: Jameson Graef Rollins @ 2011-10-09  3:21 UTC (permalink / raw)
  To: Notmuch Mail

The first test tests that the notmuch-show-refresh-view function
produces the exact same output for an unmodified show buffer.  This
test should pass since the relevant functionality has already been
applied.

The second test tests show refresh for a show buffer that has been
modified by navigation and message visibility toggling.  Ideally
refresh-view should preserve this state of the notmuch-show buffer.
Unfortunately it currently does not, so this test is know to be broken
and is marked as such.
---
 test/emacs |   18 ++++++++++++++++++
 1 files changed, 18 insertions(+), 0 deletions(-)

diff --git a/test/emacs b/test/emacs
index c88e5ac..6d9cfd9 100755
--- a/test/emacs
+++ b/test/emacs
@@ -367,4 +367,22 @@ test_emacs "(notmuch-show \"id:$id\") \
             (test-visible-output \"EXPECTED\")"
 test_expect_equal_file OUTPUT EXPECTED
 
+test_begin_subtest "Refresh show buffer"
+test_emacs '(notmuch-show "id:f35dbb950911171438k5df6eb56k77b6c0944e2e79ae@mail.gmail.com")
+	    (test-visible-output "EXPECTED")
+	    (notmuch-show-refresh-view)
+	    (test-visible-output)'
+test_expect_equal_file OUTPUT EXPECTED
+
+test_begin_subtest "Refresh modified show buffer"
+test_subtest_known_broken
+test_emacs '(notmuch-show "id:f35dbb950911171438k5df6eb56k77b6c0944e2e79ae@mail.gmail.com")
+            (notmuch-show-toggle-message)
+            (notmuch-show-next-message)
+            (notmuch-show-toggle-message)
+	    (test-visible-output "EXPECTED")
+	    (notmuch-show-refresh-view)
+	    (test-visible-output)'
+test_expect_equal_file OUTPUT EXPECTED
+
 test_done
-- 
1.7.6.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] test: add two emacs tests for show mode refresh
  2011-10-09  3:21 ` [PATCH] test: add two emacs tests for show mode refresh Jameson Graef Rollins
@ 2011-10-09  3:26   ` Jameson Graef Rollins
  2011-10-09 11:31   ` David Bremner
  1 sibling, 0 replies; 3+ messages in thread
From: Jameson Graef Rollins @ 2011-10-09  3:26 UTC (permalink / raw)
  To: Notmuch Mail

[-- Attachment #1: Type: text/plain, Size: 359 bytes --]

Sorry, this was supposed to be in-reply-to

id:"1306627784-3401-1-git-send-email-jrollins@finestructure.net"

but somehow that got missed.

This adds tests for the notmuch-show-refresh-view function.  One of them
is known broken and indicates functionality that we would certainly like
to see from this function but that is currently not implemented.

jamie.

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] test: add two emacs tests for show mode refresh
  2011-10-09  3:21 ` [PATCH] test: add two emacs tests for show mode refresh Jameson Graef Rollins
  2011-10-09  3:26   ` Jameson Graef Rollins
@ 2011-10-09 11:31   ` David Bremner
  1 sibling, 0 replies; 3+ messages in thread
From: David Bremner @ 2011-10-09 11:31 UTC (permalink / raw)
  To: Jameson Graef Rollins, Notmuch Mail

On Sat,  8 Oct 2011 20:21:26 -0700, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> The first test tests that the notmuch-show-refresh-view function
> produces the exact same output for an unmodified show buffer.  This
> test should pass since the relevant functionality has already been
> applied.

pushed, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-10-09 11:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <id:1306627784-3401-1-git-send-email-jrollins@finestructure.net>
2011-10-09  3:21 ` [PATCH] test: add two emacs tests for show mode refresh Jameson Graef Rollins
2011-10-09  3:26   ` Jameson Graef Rollins
2011-10-09 11:31   ` David Bremner

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).