From: "Łukasz Stelmach" <l.stelmach@samsung.com>
To: tomi.ollila@iki.fi
Cc: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] cli/new: Avoid printing "\033[K" to non-terminal output
Date: Fri, 10 Mar 2017 10:21:27 +0100 [thread overview]
Message-ID: <874lz1trl4.fsf%l.stelmach@samsung.com> (raw)
In-Reply-To: <87bmta6328.fsf@tethera.net>
[-- Attachment #1: Type: text/plain, Size: 1323 bytes --]
Tomi Ollila wrote:
>It was <2017-03-09 czw 13:35>, when David Bremner wrote:
>> Łukasz Stelmach <l.stelmach@samsung.com> writes:
>>
>>> ---
>>> notmuch-new.c | 5 ++---
>>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/notmuch-new.c b/notmuch-new.c
>>> index 1321263..44174ad 100644
>>> --- a/notmuch-new.c
>>> +++ b/notmuch-new.c
>>> @@ -905,10 +905,9 @@ print_results (const add_files_state_t *state)
>>> state->processed_files == 1 ? "file" : "total files");
>>> notmuch_time_print_formatted_seconds (elapsed);
>>> if (elapsed > 1)
>>> - printf (" (%d files/sec.).\033[K\n",
>>> + printf (" (%d files/sec.)",
>>> (int) (state->processed_files / elapsed));
>>> - else
>>> - printf (".\033[K\n");
>>> + printf(".%s\n", (state->output_is_a_tty) ? "\033[K" : "");
>>> }
>>
>> Other than missing a space after printf (which I can hopefully remember
>> to add when I commit it, this looks fine).
>
> I looked this briefly a while ago -- there were quite a few \033[K:s
> that were not taken care of... would those have needed to be...
As far as I can tell this is the only one left, that is not under the
condition of output_is_a_tty (at least in notmuch-new).
--
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]
next prev parent reply other threads:[~2017-03-10 9:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170302122208eucas1p2dcea0ead891ae5216a5e734a5f079db6@eucas1p2.samsung.com>
2017-03-02 12:22 ` [PATCH] cli/new: Avoid printing "\033[K" to non-terminal output Łukasz Stelmach
[not found] ` <87bmta6328.fsf@tethera.net>
2017-03-10 9:21 ` Łukasz Stelmach [this message]
2017-03-10 11:44 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874lz1trl4.fsf%l.stelmach@samsung.com \
--to=l.stelmach@samsung.com \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).