From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 632FC6DE1BAD for ; Fri, 10 Mar 2017 01:21:45 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -3.65 X-Spam-Level: X-Spam-Status: No, score=-3.65 tagged_above=-999 required=5 tests=[AWL=1.381, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DTmjT2IUNKiI for ; Fri, 10 Mar 2017 01:21:44 -0800 (PST) Received: from mailout4.w1.samsung.com (mailout4.w1.samsung.com [210.118.77.14]) by arlo.cworth.org (Postfix) with ESMTPS id 4A43B6DE1B75 for ; Fri, 10 Mar 2017 01:21:44 -0800 (PST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OML00I40E046F80@mailout4.w1.samsung.com> for notmuch@notmuchmail.org; Fri, 10 Mar 2017 09:21:40 +0000 (GMT) Received: from eusmges4.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20170310092139eucas1p193a2806c83f70130c168ecf5e2155dbc~qetkYOSgp1831918319eucas1p1v; Fri, 10 Mar 2017 09:21:39 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges4.samsung.com (EUCPMTA) with SMTP id 9A.89.28517.32072C85; Fri, 10 Mar 2017 09:21:39 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20170310092138eucas1p2c85a6161c9836e5cde195cb32a1e3fdb~qetjZi5w20654906549eucas1p2y; Fri, 10 Mar 2017 09:21:38 +0000 (GMT) X-AuditID: cbfec7f4-f79716d000006f65-a9-58c270236af5 Received: from eusync4.samsung.com ( [203.254.199.214]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id C1.21.06687.48072C85; Fri, 10 Mar 2017 09:23:16 +0000 (GMT) Received: from localhost ([106.116.147.110]) by eusync4.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OML00CYGE02LM60@eusync4.samsung.com>; Fri, 10 Mar 2017 09:21:38 +0000 (GMT) To: tomi.ollila@iki.fi Cc: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH] cli/new: Avoid printing "\033[K" to non-terminal output From: =?utf-8?Q?=C5=81ukasz_Stelmach?= Date: Fri, 10 Mar 2017 10:21:27 +0100 In-reply-to: <87bmta6328.fsf@tethera.net> Message-id: <874lz1trl4.fsf%l.stelmach@samsung.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-version: 1.0 Content-type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupgleLIzCtJLcpLzFFi42LZduzneV3lgkMRBv1PxCxutHYzWly/OZPZ 4s3KeawOzB6Hvy5k8Xi26hazx5ZD75kDmKO4bFJSczLLUov07RK4Mg593MlccJO/YsOhNqYG xtm8XYycHBICJhK3fnazQthiEhfurWcDsYUEljJKtO716GLkArI/M0r8fHmRvYuRA6zh4ato iPgyRoneN3uYIJwvQEXne5hAukWAJt2+Ng3MZhawkzjyvYsRxBYW8JFYd2ISWJxNwF6i/8g+ FpChLAKqEp2tYEdwCmhKbLx4khUkzCtgLPG+3xMkLCpgKXHt8U+wTl4BQYkfk++xQEzPlfjU 9J8d5AQJgXnsEt92/GCBuFNWYtMBZoi/XCSeXz/NDmELS7w6vgXKlpHo7DjIBNHbzyhxeP53 qMQURonFCx0gbGuJP6smskEs45OYtG06M8R8XomONiGIEg+J2eePMkLYjhJLj3xigQTJTkaJ BzdfMU9glJuF5O5ZSO6eBTSKGejl9bv0IcLaEssWvmaGsG0l1q17z7KAkXUVo0hqaXFuemqx iV5xYm5xaV66XnJ+7iZGYJo4/e/4lx2Mi49ZHWIU4GBU4uGdkX0wQog1say4MvcQowrQmEcb Vl9glGLJy89LVRLhdU86FCHEm5JYWZValB9fVJqTWnyIUZqDRUmcd8+CK+FCAumJJanZqakF qUUwWSYOTqkGRl7viv79hzj3rV29+u253c9vPxZ4/08g74nA0ZwdrRazMv9w9GlsKZ/2WLjo Wo3PyushzfaN+rLeLuHyIq/XLE5sbbzOKnq557DM5VLnqwpBOW/ZlXSUf83MvTaP8ceC4E0t DKej187W2VpR7fXOUaFYZ//WsPtzZPaKK4qecfv6ZMErp4llK5VYijMSDbWYi4oTAbbtCPAb AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBIsWRmVeSWpSXmKPExsVy+t/xa7otBYciDDZ9VrC40drNaHH95kxm izcr57E6MHsc/rqQxePZqlvMHlsOvWcOYI5ys8lITUxJLVJIzUvOT8nMS7dVCg1x07VQUshL zE21VYrQ9Q0JUlIoS8wpBfKMDNCAg3OAe7CSvl2CW8ahjzuZC27yV2w41MbUwDibt4uRg0NC wETi4avoLkZOIFNM4sK99WwgtpDAEkaJax9quxi5gOxvjBI/+z4wgyREgIpuX5vGBGIzC9hJ HPnexQhiCwv4SKw7MYkJomE3o8S5rS1gk9gE7CX6j+xjAVnGIqAq0dnKChLmFNCU2HjxJCtI mFfAWOJ9vydIWFTAUuLa459g43kFBCV+TL7HArEqW+LCxTcsExj5ZyFJzUKSmgU0iRlo6vpd +hBhbYllC18zQ9i2EuvWvWdZwMi6ilEktbQ4Nz232FCvODG3uDQvXS85P3cTIzBmth37uXkH 46WNwYcYBTgYlXh4P+QejBBiTSwrrsw9xKgCNObRhtUXGKVY8vLzUpVEeN2TDkUI8aYkVlal FuXHF5XmpBYfYjQF+nIis5Rocj4wzvNK4g1NDM0tDY2MLSzMjYyUxHlLPlwJFxJITyxJzU5N LUgtgulj4uCUamCML1fkYfvX9+u3TzCnbfIuZt/8MuWqRVd2KHEcffJHxYfNJWqPp3hp//L+ Gl5P3vPH/JdURzjGsq+8eWTFTV0Fl3nZdoxli85U6Rxd8W9tlu8+QXa38zb79zo2KeYXN2V2 LgvubOrzZyjpcTga84NBJKutZPMRu1nnT/8X93nPqSmWsfPTZSWW4oxEQy3mouJEAMIcsDK7 AgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170310092138eucas1p2c85a6161c9836e5cde195cb32a1e3fdb X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?THVrYXN6IFN0ZWxtYWNoG1NSUE9MLVN5c3RlbSAoVFApGw==?= =?UTF-8?B?7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?THVrYXN6IFN0ZWxtYWNoG1NSUE9MLVN5c3RlbSAoVFApG1Nh?= =?UTF-8?B?bXN1bmcgRWxlY3Ryb25pY3MbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTY=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170302122208eucas1p2dcea0ead891ae5216a5e734a5f079db6 X-RootMTR: 20170302122208eucas1p2dcea0ead891ae5216a5e734a5f079db6 References: <1488457321-24449-1-git-send-email-l.stelmach@samsung.com> <87bmta6328.fsf@tethera.net> X-Mailman-Approved-At: Sat, 11 Mar 2017 08:57:26 -0800 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Mar 2017 09:21:45 -0000 --=-=-= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Tomi Ollila wrote: >It was <2017-03-09 czw 13:35>, when David Bremner wrote: >> =C5=81ukasz Stelmach writes: >> >>> --- >>> notmuch-new.c | 5 ++--- >>> 1 file changed, 2 insertions(+), 3 deletions(-) >>> >>> diff --git a/notmuch-new.c b/notmuch-new.c >>> index 1321263..44174ad 100644 >>> --- a/notmuch-new.c >>> +++ b/notmuch-new.c >>> @@ -905,10 +905,9 @@ print_results (const add_files_state_t *state) >>> state->processed_files =3D=3D 1 ? "file" : "total files"); >>> notmuch_time_print_formatted_seconds (elapsed); >>> if (elapsed > 1) >>> - printf (" (%d files/sec.).\033[K\n", >>> + printf (" (%d files/sec.)", >>> (int) (state->processed_files / elapsed)); >>> - else >>> - printf (".\033[K\n"); >>> + printf(".%s\n", (state->output_is_a_tty) ? "\033[K" : ""); >>> } >> >> Other than missing a space after printf (which I can hopefully remember >> to add when I commit it, this looks fine). > > I looked this briefly a while ago -- there were quite a few \033[K:s > that were not taken care of... would those have needed to be... As far as I can tell this is the only one left, that is not under the condition of output_is_a_tty (at least in notmuch-new). =2D-=20 =C5=81ukasz Stelmach Samsung R&D Institute Poland Samsung Electronics --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBCAAGBQJYwnAYAAoJELCuHpyYpYAQCt8H/RXAIdQbtfgfT7ZgMDTsNMyv fF8EVtmlmOp2E2LGiKKNc3x5yPWVgU6Me1M28F/Kgvvt1U7ivT/ggoQLISH3IknP FpIKaYC3NOX2gD4bPbe+77Gc9xo0Cby4p40ucbQWfwNr/j0m6tw2B5vpM3szzdN+ 4iV7/U+42cJS8YZJ8nRFjTvyQ8+/sXCuEtK51iG7OaBHtHY/qRWYE/juCFnYfr/N sj0PLuG+d/lPgA4TKUQzJDxCo8468xmgbDKdoyAbN31//Uz+hO/p93sOjGCrrcXW KuRoZMkWeOiI6/DcnBgBl35avuWMRwpwZfluwaGSlvGBbqh0vqMYZFbY4qDxhbM= =wn2n -----END PGP SIGNATURE----- --=-=-=--