* [PATCH] test: fix hardcoded paths in T050-new.sh
@ 2018-05-26 23:54 David Bremner
2018-05-27 16:11 ` Tomi Ollila
0 siblings, 1 reply; 3+ messages in thread
From: David Bremner @ 2018-05-26 23:54 UTC (permalink / raw)
To: notmuch
The previous paths will fail almost everywhere.
---
test/T050-new.sh | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/test/T050-new.sh b/test/T050-new.sh
index 40c5e6fa..dfc8508f 100755
--- a/test/T050-new.sh
+++ b/test/T050-new.sh
@@ -238,12 +238,12 @@ notmuch config set new.ignore .git ignored_file .ignored_hidden_file
touch "${MAIL_DIR}"/.git # change .git's mtime for notmuch new to rescan.
NOTMUCH_NEW --debug 2>&1 | sort > OUTPUT
cat <<EOF > EXPECTED
-(D) add_files, pass 1: explicitly ignoring /home/bremner/software/upstream/notmuch/test/tmp.T050-new/mail/.git
-(D) add_files, pass 1: explicitly ignoring /home/bremner/software/upstream/notmuch/test/tmp.T050-new/mail/.ignored_hidden_file
-(D) add_files, pass 1: explicitly ignoring /home/bremner/software/upstream/notmuch/test/tmp.T050-new/mail/ignored_file
-(D) add_files, pass 2: explicitly ignoring /home/bremner/software/upstream/notmuch/test/tmp.T050-new/mail/.git
-(D) add_files, pass 2: explicitly ignoring /home/bremner/software/upstream/notmuch/test/tmp.T050-new/mail/.ignored_hidden_file
-(D) add_files, pass 2: explicitly ignoring /home/bremner/software/upstream/notmuch/test/tmp.T050-new/mail/ignored_file
+(D) add_files, pass 1: explicitly ignoring ${MAIL_DIR}/.git
+(D) add_files, pass 1: explicitly ignoring ${MAIL_DIR}/.ignored_hidden_file
+(D) add_files, pass 1: explicitly ignoring ${MAIL_DIR}/ignored_file
+(D) add_files, pass 2: explicitly ignoring ${MAIL_DIR}/.git
+(D) add_files, pass 2: explicitly ignoring ${MAIL_DIR}/.ignored_hidden_file
+(D) add_files, pass 2: explicitly ignoring ${MAIL_DIR}/ignored_file
Added 1 new message to the database.
EOF
test_expect_equal_file EXPECTED OUTPUT
--
2.17.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] test: fix hardcoded paths in T050-new.sh
2018-05-26 23:54 [PATCH] test: fix hardcoded paths in T050-new.sh David Bremner
@ 2018-05-27 16:11 ` Tomi Ollila
2018-05-27 21:59 ` David Bremner
0 siblings, 1 reply; 3+ messages in thread
From: Tomi Ollila @ 2018-05-27 16:11 UTC (permalink / raw)
To: David Bremner, notmuch
On Sat, May 26 2018, David Bremner wrote:
> The previous paths will fail almost everywhere.
Who reviewed this commit? me? ;)
+1
Tomi
> ---
> test/T050-new.sh | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/test/T050-new.sh b/test/T050-new.sh
> index 40c5e6fa..dfc8508f 100755
> --- a/test/T050-new.sh
> +++ b/test/T050-new.sh
> @@ -238,12 +238,12 @@ notmuch config set new.ignore .git ignored_file .ignored_hidden_file
> touch "${MAIL_DIR}"/.git # change .git's mtime for notmuch new to rescan.
> NOTMUCH_NEW --debug 2>&1 | sort > OUTPUT
> cat <<EOF > EXPECTED
> -(D) add_files, pass 1: explicitly ignoring /home/bremner/software/upstream/notmuch/test/tmp.T050-new/mail/.git
> -(D) add_files, pass 1: explicitly ignoring /home/bremner/software/upstream/notmuch/test/tmp.T050-new/mail/.ignored_hidden_file
> -(D) add_files, pass 1: explicitly ignoring /home/bremner/software/upstream/notmuch/test/tmp.T050-new/mail/ignored_file
> -(D) add_files, pass 2: explicitly ignoring /home/bremner/software/upstream/notmuch/test/tmp.T050-new/mail/.git
> -(D) add_files, pass 2: explicitly ignoring /home/bremner/software/upstream/notmuch/test/tmp.T050-new/mail/.ignored_hidden_file
> -(D) add_files, pass 2: explicitly ignoring /home/bremner/software/upstream/notmuch/test/tmp.T050-new/mail/ignored_file
> +(D) add_files, pass 1: explicitly ignoring ${MAIL_DIR}/.git
> +(D) add_files, pass 1: explicitly ignoring ${MAIL_DIR}/.ignored_hidden_file
> +(D) add_files, pass 1: explicitly ignoring ${MAIL_DIR}/ignored_file
> +(D) add_files, pass 2: explicitly ignoring ${MAIL_DIR}/.git
> +(D) add_files, pass 2: explicitly ignoring ${MAIL_DIR}/.ignored_hidden_file
> +(D) add_files, pass 2: explicitly ignoring ${MAIL_DIR}/ignored_file
> Added 1 new message to the database.
> EOF
> test_expect_equal_file EXPECTED OUTPUT
> --
> 2.17.0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] test: fix hardcoded paths in T050-new.sh
2018-05-27 16:11 ` Tomi Ollila
@ 2018-05-27 21:59 ` David Bremner
0 siblings, 0 replies; 3+ messages in thread
From: David Bremner @ 2018-05-27 21:59 UTC (permalink / raw)
To: Tomi Ollila, notmuch
Tomi Ollila <tomi.ollila@iki.fi> writes:
> On Sat, May 26 2018, David Bremner wrote:
>
>> The previous paths will fail almost everywhere.
>
> Who reviewed this commit? me? ;)
>
> +1
>
Hopefully we got it right this time, that's part of 0.27_rc0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-27 21:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-26 23:54 [PATCH] test: fix hardcoded paths in T050-new.sh David Bremner
2018-05-27 16:11 ` Tomi Ollila
2018-05-27 21:59 ` David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).