From: David Bremner <david@tethera.net>
To: jao <jao@gnu.org>, notmuch@notmuchmail.org
Cc: jao <jao@gnu.org>
Subject: Re: [PATCH v3 1/2] emacs: new command notmuch-tree-filter
Date: Sat, 21 Aug 2021 07:32:18 -0700 [thread overview]
Message-ID: <874kbilvgt.fsf@tethera.net> (raw)
In-Reply-To: <20210804002309.1059883-2-jao@gnu.org>
jao <jao@gnu.org> writes:
> This command is analogous to notmuch-filter, but is defined on tree
> mode buffers.
> ---
> doc/notmuch-emacs.rst | 3 +++
> emacs/notmuch-tree.el | 16 ++++++++++++++++
> 2 files changed, 19 insertions(+)
>
> diff --git a/doc/notmuch-emacs.rst b/doc/notmuch-emacs.rst
> index 952fe2a5..5accfa60 100644
> --- a/doc/notmuch-emacs.rst
> +++ b/doc/notmuch-emacs.rst
> @@ -302,6 +302,9 @@ tags.
> ``o`` ``notmuch-tree-toggle-order``
> |docstring::notmuch-tree-toggle-order|
>
> +``l`` ``notmuch-tree-filter``
> + Filter or LIMIT the current search results based on an additional query string
> +
> ``g`` ``=``
> Refresh the buffer
Please also update devel/emacs-keybindings.org, which is to help
developers avoid collisions or bad keybinding choices.
Other than that this patch looks OK to me.
d
next prev parent reply other threads:[~2021-08-21 14:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 0:23 [EMACS] New commands notmuch-tree-filter{,-by-tag} jao
2021-08-04 0:23 ` [PATCH v3 1/2] emacs: new command notmuch-tree-filter jao
2021-08-21 14:32 ` David Bremner [this message]
2021-08-04 0:23 ` [PATCH v3 2/2] emacs: new command notmuch-tree-filter-by-tag jao
2021-08-21 14:35 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kbilvgt.fsf@tethera.net \
--to=david@tethera.net \
--cc=jao@gnu.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).