From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id mIqMHgIPIWFfJwEAgWs5BA (envelope-from ) for ; Sat, 21 Aug 2021 16:34:42 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id yBY5GgIPIWHQBQAAB5/wlQ (envelope-from ) for ; Sat, 21 Aug 2021 14:34:42 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 320FF4239 for ; Sat, 21 Aug 2021 16:34:42 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 68DA720325; Sat, 21 Aug 2021 10:34:38 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id EE99F2030A for ; Sat, 21 Aug 2021 10:34:34 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id BB4EB5FD5C; Sat, 21 Aug 2021 10:34:34 -0400 (EDT) Received: (nullmailer pid 785272 invoked by uid 1000); Sat, 21 Aug 2021 14:32:18 -0000 From: David Bremner To: jao , notmuch@notmuchmail.org Subject: Re: [PATCH v3 1/2] emacs: new command notmuch-tree-filter In-Reply-To: <20210804002309.1059883-2-jao@gnu.org> References: <20210804002309.1059883-1-jao@gnu.org> <20210804002309.1059883-2-jao@gnu.org> Date: Sat, 21 Aug 2021 07:32:18 -0700 Message-ID: <874kbilvgt.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: O26DU5V2XRAUOOV6DK2OSI4NZPDKUQEN X-Message-ID-Hash: O26DU5V2XRAUOOV6DK2OSI4NZPDKUQEN X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: jao X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1629556482; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=CrAH+6GcE6zexVMfhLP2ZYvYyxdozCaxjM6vScdUKHc=; b=Dm5fWaVVmQZ8Cz1QpRB6vgFSlWRSv0jzM4DWZTWrAzTdtq/PKXbtheVW0JduszIxoUph9+ JzIz9Qj1SxImUhGxYwCqC1MXYyVPWhzACeZtrdxQ2SmoGE7Ob/m1RlcinGqnVlx8GHzDmu gKl8HCz+aasnlYoaXgduI8hhWgte1KS4yK+uabg2opFHRXvk3B/owVJkV7xznIFKh/idf5 JA91wgOZfFO2pZ02H2uK2pyKU2YMQ5BEsLWm0V9P5Vnv0JFW6M/ig+2GzwK4NmLKIOjZsz dyIDPjaRDDsIHWyStlsEBe2HnJ8nzo0FvIGogc4L+SuHumr8hzPCB25+94VW0g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1629556482; a=rsa-sha256; cv=none; b=mozYvlUCOGe/FRv4E3anusJ7+aoM0noTOvDqCteVtGtGcxjkj9lMiSbTAVla1NNpWaqBdt SktvEPhtm5QFs+mDtXdL+Qrq2XBrVVSO++Lt7adLHFq+mGI3El/8hO2jGSv97bpd3kaGGe fdldqcJ3+YPTYWsP3PFPNjfRj1v4rQm1pRx0oZHv6NG6LE/9snHR+Fd30s2yePF+KU9zi7 MyLObNwx3fra90KTILjnPNswFcwyNq33G7wclrOVxu+7vZV5WRCNquSzKglCgY5w2oHjZC 1wIVUuCKKz5A9X7WACxEefdFNxDafy69c83Tm4Jd2UwGSo1tCdhrP419WRJaiQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -1.94 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 320FF4239 X-Spam-Score: -1.94 X-Migadu-Scanner: scn0.migadu.com X-TUID: k3GhYdjlPUqK jao writes: > This command is analogous to notmuch-filter, but is defined on tree > mode buffers. > --- > doc/notmuch-emacs.rst | 3 +++ > emacs/notmuch-tree.el | 16 ++++++++++++++++ > 2 files changed, 19 insertions(+) > > diff --git a/doc/notmuch-emacs.rst b/doc/notmuch-emacs.rst > index 952fe2a5..5accfa60 100644 > --- a/doc/notmuch-emacs.rst > +++ b/doc/notmuch-emacs.rst > @@ -302,6 +302,9 @@ tags. > ``o`` ``notmuch-tree-toggle-order`` > |docstring::notmuch-tree-toggle-order| > > +``l`` ``notmuch-tree-filter`` > + Filter or LIMIT the current search results based on an additional query string > + > ``g`` ``=`` > Refresh the buffer Please also update devel/emacs-keybindings.org, which is to help developers avoid collisions or bad keybinding choices. Other than that this patch looks OK to me. d