[PATCH] debian: drop export-dir from gbp.conf

[PATCH] debian: drop export-dir from gbp.conf

[Daniel Kahn Gillmor]

No one knows why this invocation is here.  it does weird things during
the build.  If a developer really wants this behavior, they can
specify it in their own ~/.gbp.conf

Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
---
 debian/gbp.conf | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/debian/gbp.conf b/debian/gbp.conf
index 6cb451a4..a1c8735d 100644
--- a/debian/gbp.conf
+++ b/debian/gbp.conf
@@ -7,9 +7,6 @@ upstream-branch = master
 # The default branch for the debian patch (no patch in our case)
 debian-branch = master
 
-# Directory for performing the build
-export-dir = ./debian-build
-
 # Format for upstream tags
 upstream-tag = %(version)s
 
-- 
2.15.1

Re: [PATCH] debian: drop export-dir from gbp.conf

[David Bremner]

Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:

> No one knows why this invocation is here.  it does weird things during
> the build.  If a developer really wants this behavior, they can
> specify it in their own ~/.gbp.conf
>

pushed.

d

Re: [PATCH] debian: drop export-dir from gbp.conf

[Carl Worth]

[-- Attachment #1: Type: text/plain, Size: 806 bytes --]

On Tue, Feb 06 2018, Daniel Kahn Gillmor wrote:
> No one knows why this invocation is here.  it does weird things during
> the build.  If a developer really wants this behavior, they can
> specify it in their own ~/.gbp.conf

I imagine I'm to blame for this one?

One of the things that has always bugged me about a bunch of that Debian
build utilities is that they spit out results into the parent directory
of the current working directory from where they are invoked.

I've always found that be really mystifying, (no well-behaved program
does such a thing).

I _think_ the export-dir directive here was something I found that made
git-buildpackage behave more sane in this regard.

But I'm not the one doing frequent package builds of notmuch these days,
so feel free to do what you think best.

-Carl

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

Re: [PATCH] debian: drop export-dir from gbp.conf

[Daniel Kahn Gillmor]

Hi Carl--

On Fri 2018-02-09 19:08:59 -0800, Carl Worth wrote:
> One of the things that has always bugged me about a bunch of that Debian
> build utilities is that they spit out results into the parent directory
> of the current working directory from where they are invoked.

i agree that this is a legacy thing and not something you'd typically
want to introduce into new systems you were building today.  but, it's
the status quo…

> I _think_ the export-dir directive here was something I found that made
> git-buildpackage behave more sane in this regard.

yup, and you can still get those same benefits by putting export-dir in
your own ~/.gbp.conf, but you might prefer ./debian-build, while i
prefer ../debian-build and still someone else prefers
/home/foo/debian-uploads.  so the user-specific ~/.gbp.conf is a better
place for this config setting than the project-specific debian/gbp.conf.

      --dkg