message-default-mail-headers not working in notmuch 0.22

message-default-mail-headers not working in notmuch 0.22

[Sebastian Fischmeister]

Hi,

After upgrading to notmuch 0.22, my emacs config seems broken:

(setq message-default-mail-headers "Reply-to: me@example.com\nBcc: me@example.com")

When creating a new mail, it has no header other than "To:" and
"Subject:".

Since I cannot find any item in the NEWS related to this release, is
this expected behaviour?


  Sebastian

Re: message-default-mail-headers not working in notmuch 0.22

[David Edmondson]

On Fri, Apr 29 2016, Sebastian Fischmeister wrote:
> After upgrading to notmuch 0.22, my emacs config seems broken:
>
> (setq message-default-mail-headers "Reply-to: me@example.com\nBcc: me@example.com")
>
> When creating a new mail, it has no header other than "To:" and
> "Subject:".
>
> Since I cannot find any item in the NEWS related to this release, is
> this expected behaviour?

No, it's not intended. Please try this patch:

diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
index 0445975..399e138 100644
--- a/emacs/notmuch-mua.el
+++ b/emacs/notmuch-mua.el
@@ -338,7 +338,10 @@ modified. This function is notmuch addaptation of
 	  ;; We need to convert any string input, eg from rmail-start-mail.
 	  (dolist (h other-headers other-headers)
 	    (if (stringp (car h)) (setcar h (intern (capitalize (car h))))))))
-	(args (list yank-action send-actions)))
+	(args (list yank-action send-actions))
+	;; Cause `message-setup-1' to do things relevant for mail,
+	;; such as observe `message-default-mail-headers'.
+	(message-this-is-mail t))
     ;; message-setup-1 in Emacs 23 does not accept return-action
     ;; argument. Pass it only if it is supplied by the caller. This
     ;; will never be the case when we're called by `compose-mail' in

Re: message-default-mail-headers not working in notmuch 0.22

[David Bremner]

Sebastian Fischmeister <sfischme@uwaterloo.ca> writes:

> Hi,
>
> After upgrading to notmuch 0.22, my emacs config seems broken:
>
> (setq message-default-mail-headers "Reply-to: me@example.com\nBcc: me@example.com")
>
> When creating a new mail, it has no header other than "To:" and
> "Subject:".
>
> Since I cannot find any item in the NEWS related to this release, is
> this expected behaviour?

Looks like this problem was introduced in commit 570c0aeb40bd.
Confusingly it looks like it has something to do with the different
handling of "message-default-headers" and "message-default-mail-headers"
in message-setup-1.

d

Re: message-default-mail-headers not working in notmuch 0.22

[Sebastian Fischmeister]

I can confirm that this fixes the problem.

Thanks for the quick reply!

  Sebastian

David Edmondson <dme@dme.org> writes:

> On Fri, Apr 29 2016, Sebastian Fischmeister wrote:
>> After upgrading to notmuch 0.22, my emacs config seems broken:
>>
>> (setq message-default-mail-headers "Reply-to: me@example.com\nBcc: me@example.com")
>>
>> When creating a new mail, it has no header other than "To:" and
>> "Subject:".
>>
>> Since I cannot find any item in the NEWS related to this release, is
>> this expected behaviour?
>
> No, it's not intended. Please try this patch:
>
> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
> index 0445975..399e138 100644
> --- a/emacs/notmuch-mua.el
> +++ b/emacs/notmuch-mua.el
> @@ -338,7 +338,10 @@ modified. This function is notmuch addaptation of
>  	  ;; We need to convert any string input, eg from rmail-start-mail.
>  	  (dolist (h other-headers other-headers)
>  	    (if (stringp (car h)) (setcar h (intern (capitalize (car h))))))))
> -	(args (list yank-action send-actions)))
> +	(args (list yank-action send-actions))
> +	;; Cause `message-setup-1' to do things relevant for mail,
> +	;; such as observe `message-default-mail-headers'.
> +	(message-this-is-mail t))
>      ;; message-setup-1 in Emacs 23 does not accept return-action
>      ;; argument. Pass it only if it is supplied by the caller. This
>      ;; will never be the case when we're called by `compose-mail' in

Re: message-default-mail-headers not working in notmuch 0.22

[Michal Sojka]

On Fri, Apr 29 2016, David Edmondson wrote:
> On Fri, Apr 29 2016, Sebastian Fischmeister wrote:
>> After upgrading to notmuch 0.22, my emacs config seems broken:
>>
>> (setq message-default-mail-headers "Reply-to: me@example.com\nBcc: me@example.com")
>>
>> When creating a new mail, it has no header other than "To:" and
>> "Subject:".
>>
>> Since I cannot find any item in the NEWS related to this release, is
>> this expected behaviour?
>
> No, it's not intended. Please try this patch:
>
> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
> index 0445975..399e138 100644
> --- a/emacs/notmuch-mua.el
> +++ b/emacs/notmuch-mua.el
> @@ -338,7 +338,10 @@ modified. This function is notmuch addaptation of
>  	  ;; We need to convert any string input, eg from rmail-start-mail.
>  	  (dolist (h other-headers other-headers)
>  	    (if (stringp (car h)) (setcar h (intern (capitalize (car h))))))))
> -	(args (list yank-action send-actions)))
> +	(args (list yank-action send-actions))
> +	;; Cause `message-setup-1' to do things relevant for mail,
> +	;; such as observe `message-default-mail-headers'.
> +	(message-this-is-mail t))

Yes, this seems to be reasonable thing to do. Thanks.

-Michal