* [PATCH] emacs: make use of `message-make-from'
@ 2016-04-08 21:43 aeuii
2016-04-09 23:10 ` David Bremner
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: aeuii @ 2016-04-08 21:43 UTC (permalink / raw)
To: notmuch
[-- Attachment #1: Type: text/plain, Size: 53 bytes --]
Please put my address in CC when replying. Thanks!
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-emacs-make-use-of-message-make-from.patch --]
[-- Type: text/x-diff, Size: 1432 bytes --]
From 4b9ab261a0ea8a31065e310c5150f522be86d37b Mon Sep 17 00:00:00 2001
From: stefan <aeuii@posteo.de>
Date: Fri, 8 Apr 2016 22:47:06 +0200
Subject: [PATCH] emacs: make use of `message-make-from'
Will respect `mail-from-style'.
---
emacs/notmuch-mua.el | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
index cfdac0e..935cbd3 100644
--- a/emacs/notmuch-mua.el
+++ b/emacs/notmuch-mua.el
@@ -318,8 +318,8 @@ modified. This function is notmuch addaptation of
(push (cons 'User-Agent user-agent) other-headers))))
(unless (assq 'From other-headers)
- (push (cons 'From (concat
- (notmuch-user-name) " <" (notmuch-user-primary-email) ">")) other-headers))
+ (push (cons 'From (message-make-from
+ (notmuch-user-name) (notmuch-user-primary-email))) other-headers))
(notmuch-mua-pop-to-buffer (message-buffer-name "mail" to)
(or switch-function (notmuch-mua-get-switch-function)))
@@ -393,7 +393,7 @@ the From: header is already filled in by notmuch."
(ido-completing-read (concat "Sender address for " name ": ") addrs
nil nil nil 'notmuch-mua-sender-history
(car addrs))))
- (concat name " <" address ">"))))
+ (message-make-from name address))))
(put 'notmuch-mua-new-mail 'notmuch-prefix-doc "... and prompt for sender")
(defun notmuch-mua-new-mail (&optional prompt-for-sender)
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] emacs: make use of `message-make-from'
2016-04-08 21:43 [PATCH] emacs: make use of `message-make-from' aeuii
@ 2016-04-09 23:10 ` David Bremner
2016-04-10 7:24 ` Tomi Ollila
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: David Bremner @ 2016-04-09 23:10 UTC (permalink / raw)
To: aeuii, notmuch
aeuii@posteo.de writes:
> - (push (cons 'From (concat
> - (notmuch-user-name) " <" (notmuch-user-primary-email) ">")) other-headers))
> + (push (cons 'From (message-make-from
> + (notmuch-user-name) (notmuch-user-primary-email))) other-headers))
Looks OK to me. Any comments from our emacs front end experts?
d
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] emacs: make use of `message-make-from'
2016-04-08 21:43 [PATCH] emacs: make use of `message-make-from' aeuii
2016-04-09 23:10 ` David Bremner
@ 2016-04-10 7:24 ` Tomi Ollila
2016-04-10 11:26 ` David Edmondson
2016-04-10 23:57 ` David Bremner
3 siblings, 0 replies; 7+ messages in thread
From: Tomi Ollila @ 2016-04-10 7:24 UTC (permalink / raw)
To: aeuii, notmuch
On Sat, Apr 09 2016, aeuii@posteo.de wrote:
> Please put my address in CC when replying. Thanks!
>
> From 4b9ab261a0ea8a31065e310c5150f522be86d37b Mon Sep 17 00:00:00 2001
> From: stefan <aeuii@posteo.de>
> Date: Fri, 8 Apr 2016 22:47:06 +0200
> Subject: [PATCH] emacs: make use of `message-make-from'
>
> Will respect `mail-from-style'.
LTGM
Tomi
> ---
> emacs/notmuch-mua.el | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
> index cfdac0e..935cbd3 100644
> --- a/emacs/notmuch-mua.el
> +++ b/emacs/notmuch-mua.el
> @@ -318,8 +318,8 @@ modified. This function is notmuch addaptation of
> (push (cons 'User-Agent user-agent) other-headers))))
>
> (unless (assq 'From other-headers)
> - (push (cons 'From (concat
> - (notmuch-user-name) " <" (notmuch-user-primary-email) ">")) other-headers))
> + (push (cons 'From (message-make-from
> + (notmuch-user-name) (notmuch-user-primary-email))) other-headers))
>
> (notmuch-mua-pop-to-buffer (message-buffer-name "mail" to)
> (or switch-function (notmuch-mua-get-switch-function)))
> @@ -393,7 +393,7 @@ the From: header is already filled in by notmuch."
> (ido-completing-read (concat "Sender address for " name ": ") addrs
> nil nil nil 'notmuch-mua-sender-history
> (car addrs))))
> - (concat name " <" address ">"))))
> + (message-make-from name address))))
>
> (put 'notmuch-mua-new-mail 'notmuch-prefix-doc "... and prompt for sender")
> (defun notmuch-mua-new-mail (&optional prompt-for-sender)
> --
> 2.7.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] emacs: make use of `message-make-from'
2016-04-08 21:43 [PATCH] emacs: make use of `message-make-from' aeuii
2016-04-09 23:10 ` David Bremner
2016-04-10 7:24 ` Tomi Ollila
@ 2016-04-10 11:26 ` David Edmondson
2016-04-10 10:05 ` Mark Walters
2016-04-10 23:57 ` David Bremner
3 siblings, 1 reply; 7+ messages in thread
From: David Edmondson @ 2016-04-10 11:26 UTC (permalink / raw)
To: aeuii, notmuch
On Fri, Apr 08 2016, aeuii@posteo.de wrote:
> Please put my address in CC when replying. Thanks!
Looks good.
> From 4b9ab261a0ea8a31065e310c5150f522be86d37b Mon Sep 17 00:00:00 2001
> From: stefan <aeuii@posteo.de>
> Date: Fri, 8 Apr 2016 22:47:06 +0200
> Subject: [PATCH] emacs: make use of `message-make-from'
>
> Will respect `mail-from-style'.
> ---
> emacs/notmuch-mua.el | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
> index cfdac0e..935cbd3 100644
> --- a/emacs/notmuch-mua.el
> +++ b/emacs/notmuch-mua.el
> @@ -318,8 +318,8 @@ modified. This function is notmuch addaptation of
> (push (cons 'User-Agent user-agent) other-headers))))
>
> (unless (assq 'From other-headers)
> - (push (cons 'From (concat
> - (notmuch-user-name) " <" (notmuch-user-primary-email) ">")) other-headers))
> + (push (cons 'From (message-make-from
> + (notmuch-user-name) (notmuch-user-primary-email))) other-headers))
>
> (notmuch-mua-pop-to-buffer (message-buffer-name "mail" to)
> (or switch-function (notmuch-mua-get-switch-function)))
> @@ -393,7 +393,7 @@ the From: header is already filled in by notmuch."
> (ido-completing-read (concat "Sender address for " name ": ") addrs
> nil nil nil 'notmuch-mua-sender-history
> (car addrs))))
> - (concat name " <" address ">"))))
> + (message-make-from name address))))
>
> (put 'notmuch-mua-new-mail 'notmuch-prefix-doc "... and prompt for sender")
> (defun notmuch-mua-new-mail (&optional prompt-for-sender)
> --
> 2.7.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] emacs: make use of `message-make-from'
2016-04-10 11:26 ` David Edmondson
@ 2016-04-10 10:05 ` Mark Walters
0 siblings, 0 replies; 7+ messages in thread
From: Mark Walters @ 2016-04-10 10:05 UTC (permalink / raw)
To: David Edmondson, aeuii, notmuch
On Sun, 10 Apr 2016, David Edmondson <dme@dme.org> wrote:
> On Fri, Apr 08 2016, aeuii@posteo.de wrote:
>> Please put my address in CC when replying. Thanks!
>
> Looks good.
I agree.
Best wishes
Mark
>
>> From 4b9ab261a0ea8a31065e310c5150f522be86d37b Mon Sep 17 00:00:00 2001
>> From: stefan <aeuii@posteo.de>
>> Date: Fri, 8 Apr 2016 22:47:06 +0200
>> Subject: [PATCH] emacs: make use of `message-make-from'
>>
>> Will respect `mail-from-style'.
>> ---
>> emacs/notmuch-mua.el | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
>> index cfdac0e..935cbd3 100644
>> --- a/emacs/notmuch-mua.el
>> +++ b/emacs/notmuch-mua.el
>> @@ -318,8 +318,8 @@ modified. This function is notmuch addaptation of
>> (push (cons 'User-Agent user-agent) other-headers))))
>>
>> (unless (assq 'From other-headers)
>> - (push (cons 'From (concat
>> - (notmuch-user-name) " <" (notmuch-user-primary-email) ">")) other-headers))
>> + (push (cons 'From (message-make-from
>> + (notmuch-user-name) (notmuch-user-primary-email))) other-headers))
>>
>> (notmuch-mua-pop-to-buffer (message-buffer-name "mail" to)
>> (or switch-function (notmuch-mua-get-switch-function)))
>> @@ -393,7 +393,7 @@ the From: header is already filled in by notmuch."
>> (ido-completing-read (concat "Sender address for " name ": ") addrs
>> nil nil nil 'notmuch-mua-sender-history
>> (car addrs))))
>> - (concat name " <" address ">"))))
>> + (message-make-from name address))))
>>
>> (put 'notmuch-mua-new-mail 'notmuch-prefix-doc "... and prompt for sender")
>> (defun notmuch-mua-new-mail (&optional prompt-for-sender)
>> --
>> 2.7.4
>>
>> _______________________________________________
>> notmuch mailing list
>> notmuch@notmuchmail.org
>> https://notmuchmail.org/mailman/listinfo/notmuch
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] emacs: make use of `message-make-from'
2016-04-08 21:43 [PATCH] emacs: make use of `message-make-from' aeuii
` (2 preceding siblings ...)
2016-04-10 11:26 ` David Edmondson
@ 2016-04-10 23:57 ` David Bremner
2016-04-11 6:29 ` aeuii
3 siblings, 1 reply; 7+ messages in thread
From: David Bremner @ 2016-04-10 23:57 UTC (permalink / raw)
To: aeuii, notmuch
aeuii@posteo.de writes:
> Please put my address in CC when replying. Thanks!
>
> From 4b9ab261a0ea8a31065e310c5150f522be86d37b Mon Sep 17 00:00:00 2001
> From: stefan <aeuii@posteo.de>
> Date: Fri, 8 Apr 2016 22:47:06 +0200
> Subject: [PATCH] emacs: make use of `message-make-from'
>
> Will respect `mail-from-style'.
pushed to master, thanks for your contribution to notmuch
d
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] emacs: make use of `message-make-from'
2016-04-10 23:57 ` David Bremner
@ 2016-04-11 6:29 ` aeuii
0 siblings, 0 replies; 7+ messages in thread
From: aeuii @ 2016-04-11 6:29 UTC (permalink / raw)
To: David Bremner, notmuch
2016-04-11 01:57 +0200, David Bremner <david@tethera.net>:
> aeuii@posteo.de writes:
>
>> Please put my address in CC when replying. Thanks!
>>
>> From 4b9ab261a0ea8a31065e310c5150f522be86d37b Mon Sep 17 00:00:00 2001
>> From: stefan <aeuii@posteo.de>
>> Date: Fri, 8 Apr 2016 22:47:06 +0200
>> Subject: [PATCH] emacs: make use of `message-make-from'
>>
>> Will respect `mail-from-style'.
>
> pushed to master, thanks for your contribution to notmuch
>
> d
Thank you!
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-04-11 6:29 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-08 21:43 [PATCH] emacs: make use of `message-make-from' aeuii
2016-04-09 23:10 ` David Bremner
2016-04-10 7:24 ` Tomi Ollila
2016-04-10 11:26 ` David Edmondson
2016-04-10 10:05 ` Mark Walters
2016-04-10 23:57 ` David Bremner
2016-04-11 6:29 ` aeuii
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).