From: Blake Sweeney <blakes.85@gmail.com>
To: Ryan Harper <rharper@shake.ath.cx>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/2] vim plugin: implement viewing/saving attachments
Date: Sun, 18 Sep 2011 20:18:56 -0400 [thread overview]
Message-ID: <4e768a72.2888ec0a.1eb5.29f3@mx.google.com> (raw)
In-Reply-To: <1316226470-30001-1-git-send-email-rharper@shake.ath.cx>
On Fri, 16 Sep 2011 21:27:48 -0500, Ryan Harper <rharper@shake.ath.cx> wrote:
> I've just started using notmuch and the vim plugin. I'm almost ready to ditch
> my mutt config, but I really needed attachment viewing/saving.
>
> I've got something functional, but I've never hacked on vimscript before so
> looking for feedback on how to clean up the patches.
>
>
> Ryan --- Give a man a beer, he'll drink for the day. Teach a man to brew,
> he'll be drunk the rest of his life.
>
In the second patch you have a typo, the function is called
NM_show_save_mime_part in the config but should be called
NM_show_save_mime_parts. Other than that, I tried it and like it.
next prev parent reply other threads:[~2011-09-19 0:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-17 2:27 [PATCH 0/2] vim plugin: implement viewing/saving attachments Ryan Harper
2011-09-17 2:27 ` [PATCH 1/2] vim plugin: Implement show_view_all_mime_parts Ryan Harper
2011-09-17 2:27 ` [PATCH 2/2] vim plugin: Implement attachment saving Ryan Harper
2012-03-03 3:12 ` Charlie Allom
2011-09-19 0:18 ` Blake Sweeney [this message]
2011-09-19 18:15 ` [PATCH 0/2] vim plugin: implement viewing/saving attachments Ryan Harper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e768a72.2888ec0a.1eb5.29f3@mx.google.com \
--to=blakes.85@gmail.com \
--cc=notmuch@notmuchmail.org \
--cc=rharper@shake.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).