From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <blakes.85@gmail.com>
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id DCE94431FD0
	for <notmuch@notmuchmail.org>; Sun, 18 Sep 2011 17:19:00 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 1.424
X-Spam-Level: *
X-Spam-Status: No, score=1.424 tagged_above=-999 required=5
	tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
	FREEMAIL_ENVFROM_END_DIGIT=2.223, FREEMAIL_FROM=0.001,
	RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id R8gILnCs6NYu for <notmuch@notmuchmail.org>;
	Sun, 18 Sep 2011 17:19:00 -0700 (PDT)
Received: from mail-yi0-f53.google.com (mail-yi0-f53.google.com
	[209.85.218.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id 66337431FB6
	for <notmuch@notmuchmail.org>; Sun, 18 Sep 2011 17:19:00 -0700 (PDT)
Received: by yie21 with SMTP id 21so5178787yie.26
	for <notmuch@notmuchmail.org>; Sun, 18 Sep 2011 17:18:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=message-id:from:subject:to:in-reply-to:references:date;
	bh=IqOMm3tGc/irTCUXJoW9pE2O1XR2vT1vHrJcPSc+bhQ=;
	b=QMmdNKB5vt0pKnS7ir08U5jucAokaYLJZY48K1BQLfOxm7Wa4t0bp+z3oW/JaRjILo
	6IB5io92VHn+Arbi9SqYR7E84o2hTR46phsEo5f4iZy+wIKB7wB9Cf3H8rbISVwpO3Oj
	lX9JRkIVvHktmpTaYfZ/uXxa33t32UM43Ai5o=
Received: by 10.236.181.101 with SMTP id k65mr10076589yhm.65.1316391538649;
	Sun, 18 Sep 2011 17:18:58 -0700 (PDT)
Received: from localhost (cpe-184-58-125-131.woh.res.rr.com. [184.58.125.131])
	by mx.google.com with ESMTPS id
	v28sm15373751yhi.11.2011.09.18.17.18.57
	(version=TLSv1/SSLv3 cipher=OTHER);
	Sun, 18 Sep 2011 17:18:58 -0700 (PDT)
Message-ID: <4e768a72.2888ec0a.1eb5.29f3@mx.google.com>
From: Blake Sweeney <blakes.85@gmail.com>
Subject: Re: [PATCH 0/2] vim plugin: implement viewing/saving attachments
To: Ryan Harper <rharper@shake.ath.cx>, notmuch@notmuchmail.org
In-Reply-To: <1316226470-30001-1-git-send-email-rharper@shake.ath.cx>
References: <1316226470-30001-1-git-send-email-rharper@shake.ath.cx>
Date: Sun, 18 Sep 2011 20:18:56 -0400
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Sep 2011 00:19:01 -0000

On Fri, 16 Sep 2011 21:27:48 -0500, Ryan Harper <rharper@shake.ath.cx> wrote:
> I've just started using notmuch and the vim plugin.  I'm almost ready to ditch
> my mutt config, but I really needed attachment viewing/saving.
> 
> I've got something functional, but I've never hacked on vimscript before so
> looking for feedback on how to clean up the patches.
> 
> 
> Ryan --- Give a man a beer, he'll drink for the day. Teach a man to brew,
> he'll be drunk the rest of his life.
> 

In the second patch you have a typo, the function is called
NM_show_save_mime_part in the config but should be called
NM_show_save_mime_parts. Other than that, I tried it and like it.