* [PATCH 0/2] vim: doc: trivial fixes
@ 2023-05-03 22:12 Felipe Contreras
2023-05-03 22:12 ` [PATCH 1/2] vim: doc: small fixes Felipe Contreras
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Felipe Contreras @ 2023-05-03 22:12 UTC (permalink / raw)
To: notmuch
These are some trivial patches long overdue from upstream.
They have been already sent in some form long time ago
id:20210418224851.88240-3-felipe.contreras@gmail.com, but hopefully in a
smaller batch they'll get merged.
Felipe Contreras (1):
vim: doc: small fixes
John Gliksberg (1):
vim: doc: minor spelling fix
vim/README | 4 ++--
vim/notmuch.txt | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
--
2.40.0+fc1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] vim: doc: small fixes
2023-05-03 22:12 [PATCH 0/2] vim: doc: trivial fixes Felipe Contreras
@ 2023-05-03 22:12 ` Felipe Contreras
2023-05-03 22:12 ` [PATCH 2/2] vim: doc: minor spelling fix Felipe Contreras
2023-05-08 19:23 ` [PATCH 0/2] vim: doc: trivial fixes David Bremner
2 siblings, 0 replies; 5+ messages in thread
From: Felipe Contreras @ 2023-05-03 22:12 UTC (permalink / raw)
To: notmuch
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
vim/README | 4 ++--
vim/notmuch.txt | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/vim/README b/vim/README
index c137bacd..777c20c0 100644
--- a/vim/README
+++ b/vim/README
@@ -53,10 +53,10 @@ Enjoy ;)
As an example to configure a key mapping to add the tag 'to-do' and archive,
this is what I use:
-let g:notmuch_rb_custom_search_maps = {
+let g:notmuch_custom_search_maps = {
\ 't': 'search_tag("+to-do -inbox")',
\ }
-let g:notmuch_rb_custom_show_maps = {
+let g:notmuch_custom_show_maps = {
\ 't': 'show_tag("+to-do -inbox")',
\ }
diff --git a/vim/notmuch.txt b/vim/notmuch.txt
index 43741022..4a038102 100644
--- a/vim/notmuch.txt
+++ b/vim/notmuch.txt
@@ -89,7 +89,7 @@ s Send
CONFIGURATION *notmuch-config*
You can add the following configurations to your `.vimrc`, or
-`~/.vim/plugin/notmuch.vim`.
+`~/.vim/after/plugin/notmuch.vim`.
*g:notmuch_folders*
@@ -138,7 +138,7 @@ You can do the same for the thread view:
If you want to count the threads instead of the messages in the folder view:
>
- let g:notmuch_folders_count_threads = 0
+ let g:notmuch_folders_count_threads = 1
<
*g:notmuch_reader*
--
2.40.0+fc1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] vim: doc: minor spelling fix
2023-05-03 22:12 [PATCH 0/2] vim: doc: trivial fixes Felipe Contreras
2023-05-03 22:12 ` [PATCH 1/2] vim: doc: small fixes Felipe Contreras
@ 2023-05-03 22:12 ` Felipe Contreras
2023-05-08 19:23 ` [PATCH 0/2] vim: doc: trivial fixes David Bremner
2 siblings, 0 replies; 5+ messages in thread
From: Felipe Contreras @ 2023-05-03 22:12 UTC (permalink / raw)
To: notmuch; +Cc: John Gliksberg
From: John Gliksberg <jg.trosh@gmail.com>
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
vim/notmuch.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vim/notmuch.txt b/vim/notmuch.txt
index 4a038102..c98f2b53 100644
--- a/vim/notmuch.txt
+++ b/vim/notmuch.txt
@@ -144,7 +144,7 @@ If you want to count the threads instead of the messages in the folder view:
*g:notmuch_reader*
*g:notmuch_sendmail*
-You can also configure your externail mail reader and sendemail program:
+You can also configure your external mail reader and sendmail program:
>
let g:notmuch_reader = 'mutt -f %s'
let g:notmuch_sendmail = 'sendmail'
--
2.40.0+fc1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 0/2] vim: doc: trivial fixes
2023-05-03 22:12 [PATCH 0/2] vim: doc: trivial fixes Felipe Contreras
2023-05-03 22:12 ` [PATCH 1/2] vim: doc: small fixes Felipe Contreras
2023-05-03 22:12 ` [PATCH 2/2] vim: doc: minor spelling fix Felipe Contreras
@ 2023-05-08 19:23 ` David Bremner
2023-05-09 3:54 ` Felipe Contreras
2 siblings, 1 reply; 5+ messages in thread
From: David Bremner @ 2023-05-08 19:23 UTC (permalink / raw)
To: Felipe Contreras, notmuch
Felipe Contreras <felipe.contreras@gmail.com> writes:
> These are some trivial patches long overdue from upstream.
>
> They have been already sent in some form long time ago
> id:20210418224851.88240-3-felipe.contreras@gmail.com, but hopefully in a
> smaller batch they'll get merged.
>
applied to master. Of course I still have no real way to review the doc
patches, but I guess won't e.g. break the build.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/2] vim: doc: trivial fixes
2023-05-08 19:23 ` [PATCH 0/2] vim: doc: trivial fixes David Bremner
@ 2023-05-09 3:54 ` Felipe Contreras
0 siblings, 0 replies; 5+ messages in thread
From: Felipe Contreras @ 2023-05-09 3:54 UTC (permalink / raw)
To: David Bremner, Felipe Contreras, notmuch
David Bremner wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
> > These are some trivial patches long overdue from upstream.
> >
> > They have been already sent in some form long time ago
> > id:20210418224851.88240-3-felipe.contreras@gmail.com, but hopefully in a
> > smaller batch they'll get merged.
>
> applied to master. Of course I still have no real way to review the doc
> patches, but I guess won't e.g. break the build.
Thanks.
There's many more notmuch-vim patches pending, and I don't think there's
many people active in this mailing list that can review them.
I used to have commit access and pushed the changes myself, I think it's
reasonable to follow some precedure where I push the changes if there's
no feedback after a reasonable amount of time. Maybe one week, maybe
one month.
Of course I have no trouble if you are the one pushing the changes, I
just don't see much point in doing that.
Either way, I'll seend the next round soon.
Cheers.
--
Felipe Contreras
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-05-09 3:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-03 22:12 [PATCH 0/2] vim: doc: trivial fixes Felipe Contreras
2023-05-03 22:12 ` [PATCH 1/2] vim: doc: small fixes Felipe Contreras
2023-05-03 22:12 ` [PATCH 2/2] vim: doc: minor spelling fix Felipe Contreras
2023-05-08 19:23 ` [PATCH 0/2] vim: doc: trivial fixes David Bremner
2023-05-09 3:54 ` Felipe Contreras
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).