unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Thomas Schneider <qsx@chaotikum.eu>, notmuch@notmuchmail.org
Subject: [PATCH 1/3] lib/database: propagate status code from _notmuch_message_delete
Date: Sat,  3 Dec 2022 22:28:55 -0400	[thread overview]
Message-ID: <20221204022857.1551514-2-david@tethera.net> (raw)
In-Reply-To: <20221204022857.1551514-1-david@tethera.net>

_notmuch_message_delete can return (at least)
NOTMUCH_STATUS_XAPIAN_EXCEPTION, which we should not ignore.
---
 lib/database.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/database.cc b/lib/database.cc
index c05d70d3..d1e5f1af 100644
--- a/lib/database.cc
+++ b/lib/database.cc
@@ -1456,7 +1456,7 @@ notmuch_database_remove_message (notmuch_database_t *notmuch,
     if (status == NOTMUCH_STATUS_SUCCESS && message) {
 	status = _notmuch_message_remove_filename (message, filename);
 	if (status == NOTMUCH_STATUS_SUCCESS)
-	    _notmuch_message_delete (message);
+	    status = _notmuch_message_delete (message);
 	else if (status == NOTMUCH_STATUS_DUPLICATE_MESSAGE_ID)
 	    _notmuch_message_sync (message);
 
-- 
2.35.2

  reply	other threads:[~2022-12-04  2:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-02 19:05 More usable error messages when exceptions are not caught Thomas Schneider
2022-12-04  2:28 ` handle exceptions in _notmuch_message_delete David Bremner
2022-12-04  2:28   ` David Bremner [this message]
2022-12-26  0:04     ` [PATCH 1/3] lib/database: propagate status code from _notmuch_message_delete Tomi Ollila
2022-12-27 16:05       ` David Bremner
2022-12-04  2:28   ` [PATCH 2/3] test: add known broken test for exception handling in _n_m_delete David Bremner
2022-12-04  2:28   ` [PATCH 3/3] lib/message: move xapian call inside try/catch block " David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221204022857.1551514-2-david@tethera.net \
    --to=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    --cc=qsx@chaotikum.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).