From: David Bremner <david@tethera.net>
To: Thomas Schneider <qsx@chaotikum.eu>, notmuch@notmuchmail.org
Subject: handle exceptions in _notmuch_message_delete
Date: Sat, 3 Dec 2022 22:28:54 -0400 [thread overview]
Message-ID: <20221204022857.1551514-1-david@tethera.net> (raw)
In-Reply-To: <wwuk039sk2p.fsf@chaotikum.eu>
It's a bit tricky to test running out of disk space in the test suite but I think I caught the exception shown
in your first backtrace (which was not attached to your mail, only pasted to IRC).
#10 GlassWritableDatabase::delete_document(unsigned int) (this=0x55da391cc550, did=413358) at /tmp/portage/dev-libs/xapian-1.4.19/work/xapian-core-1.4.19/backends/glass/glass_database.cc:1223
#11 0x00007fb7f3fba3a0 in _notmuch_message_delete(notmuch_message_t*) (message=0x55da5f74f070) at lib/message.cc:1374
#12 0x00007fb7f3fb376a in notmuch_database_remove_message(notmuch_database_t*, char const*)
(notmuch=<optimized out>, filename=0x55da41a8c440 "/var/dedup/qsx/maildir/AStA.INBOX.Admin/cur/1636633029.12621_18.neptun,U=9117:2,S") at lib/database.cc:1438
#13 0x000055da374eea01 in remove_filename (notmuch=0x55da39183530, path=0x55da41a8c440 "/var/dedup/qsx/maildir/AStA.INBOX.Admin/cur/1636633029.12621_18.neptun,U=9117:2,S", add_files_state=0x7ffe493a1440)
at notmuch-new.c:950
#14 0x000055da374eed09 in _remove_directory (notmuch=0x55da39183530, path=0x55da3faad350 "/var/dedup/qsx/maildir/AStA.INBOX.Admin/cur", add_files_state=0x7ffe493a1440) at notmuch-new.c:987
#15 0x000055da374eed79 in _remove_directory (notmuch=0x55da39183530, path=0x55da3a7349d0 "/var/dedup/qsx/maildir/AStA.INBOX.Admin", add_files_state=0x7ffe493a1440) at notmuch-new.c:998
#16 0x000055da374ed6e5 in notmuch_new_command (notmuch=0x55da39183530, argc=<optimized out>, argv=<optimized out>) at notmuch-new.c:1267
#17 0x000055da374e910b in main (argc=<optimized out>, argv=0x7ffe493a1bc8) at notmuch.c:588
next prev parent reply other threads:[~2022-12-04 2:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 19:05 More usable error messages when exceptions are not caught Thomas Schneider
2022-12-04 2:28 ` David Bremner [this message]
2022-12-04 2:28 ` [PATCH 1/3] lib/database: propagate status code from _notmuch_message_delete David Bremner
2022-12-26 0:04 ` Tomi Ollila
2022-12-27 16:05 ` David Bremner
2022-12-04 2:28 ` [PATCH 2/3] test: add known broken test for exception handling in _n_m_delete David Bremner
2022-12-04 2:28 ` [PATCH 3/3] lib/message: move xapian call inside try/catch block " David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221204022857.1551514-1-david@tethera.net \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=qsx@chaotikum.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).