From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Subject: [PATCH 8/8] test: error handling in _n_message_{add,remove}_filename
Date: Mon, 23 May 2022 20:39:01 -0300 [thread overview]
Message-ID: <20220523233901.3506880-9-david@tethera.net> (raw)
In-Reply-To: <20220523233901.3506880-1-david@tethera.net>
Use a closed database to force throwing a Xapian exception. Leave the
check vague to accomodate a potential explicit check for open database.
---
test/T566-lib-message.sh | 32 ++++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/test/T566-lib-message.sh b/test/T566-lib-message.sh
index 5b6c937e..30040634 100755
--- a/test/T566-lib-message.sh
+++ b/test/T566-lib-message.sh
@@ -340,6 +340,38 @@ cat <<EOF > EXPECTED
EOF
test_expect_equal_file EXPECTED OUTPUT
+test_begin_subtest "_notmuch_message_add_filename on closed db"
+cat c_head - c_tail <<'EOF' | test_private_C ${MAIL_DIR}
+ {
+ notmuch_private_status_t status;
+ status = _notmuch_message_add_filename (message, "some-filename");
+ printf("%d\n%d\n", message != NULL, status != NOTMUCH_STATUS_SUCCESS);
+ }
+EOF
+cat <<EOF > EXPECTED
+== stdout ==
+1
+1
+== stderr ==
+EOF
+test_expect_equal_file EXPECTED OUTPUT
+
+test_begin_subtest "_notmuch_message_remove_filename on closed db"
+cat c_head - c_tail <<'EOF' | test_private_C ${MAIL_DIR}
+ {
+ notmuch_private_status_t status;
+ status = _notmuch_message_remove_filename (message, "some-filename");
+ printf("%d\n%d\n", message != NULL, status != NOTMUCH_STATUS_SUCCESS);
+ }
+EOF
+cat <<EOF > EXPECTED
+== stdout ==
+1
+1
+== stderr ==
+EOF
+test_expect_equal_file EXPECTED OUTPUT
+
test_begin_subtest "Handle removing all tags with closed db"
cat c_head - c_tail <<'EOF' | test_C ${MAIL_DIR}
{
--
2.35.2
next prev parent reply other threads:[~2022-05-23 23:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 23:38 incrementally improve error handling in notmuch_message* David Bremner
2022-05-23 23:38 ` [PATCH 1/8] test: define test_private_C David Bremner
2022-05-23 23:38 ` [PATCH 2/8] lib/message: catch exceptions in _n_m_add_term David Bremner
2022-05-23 23:38 ` [PATCH 3/8] test: _notmuch_message_remove_term catches exceptions David Bremner
2022-05-23 23:38 ` [PATCH 4/8] lib/message: drop _notmuch_message_get_thread_id_only David Bremner
2022-05-23 23:38 ` [PATCH 5/8] lib: define macro NODISCARD David Bremner
2022-05-23 23:38 ` [PATCH 6/8] lib/message: check return status of _n_m_{add,remove}_term David Bremner
2022-05-23 23:39 ` [PATCH 7/8] lib/message: check return status from _n_m_add_{path,folder}_terms David Bremner
2022-05-23 23:39 ` David Bremner [this message]
2022-06-25 19:00 ` incrementally improve error handling in notmuch_message* David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220523233901.3506880-9-david@tethera.net \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).