unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Subject: [PATCH 4/8] lib/message: drop _notmuch_message_get_thread_id_only
Date: Mon, 23 May 2022 20:38:57 -0300	[thread overview]
Message-ID: <20220523233901.3506880-5-david@tethera.net> (raw)
In-Reply-To: <20220523233901.3506880-1-david@tethera.net>

This function has been unused since commit 4083fd8.
---
 lib/message.cc        | 17 -----------------
 lib/notmuch-private.h |  3 ---
 2 files changed, 20 deletions(-)

diff --git a/lib/message.cc b/lib/message.cc
index bf3a3419..09e5660b 100644
--- a/lib/message.cc
+++ b/lib/message.cc
@@ -340,23 +340,6 @@ _notmuch_message_get_term (notmuch_message_t *message,
     return value;
 }
 
-/*
- * For special applications where we only want the thread id, reading
- * in all metadata is a heavy I/O penalty.
- */
-const char *
-_notmuch_message_get_thread_id_only (notmuch_message_t *message)
-{
-
-    Xapian::TermIterator i = message->doc.termlist_begin ();
-    Xapian::TermIterator end = message->doc.termlist_end ();
-
-    message->thread_id = _notmuch_message_get_term (message, i, end,
-						    _find_prefix ("thread"));
-    return message->thread_id;
-}
-
-
 static void
 _notmuch_message_ensure_metadata (notmuch_message_t *message, void *field)
 {
diff --git a/lib/notmuch-private.h b/lib/notmuch-private.h
index 3cc79bc4..c63cfe5e 100644
--- a/lib/notmuch-private.h
+++ b/lib/notmuch-private.h
@@ -586,9 +586,6 @@ _notmuch_message_add_reply (notmuch_message_t *message,
 void
 _notmuch_message_remove_unprefixed_terms (notmuch_message_t *message);
 
-const char *
-_notmuch_message_get_thread_id_only (notmuch_message_t *message);
-
 size_t _notmuch_message_get_thread_depth (notmuch_message_t *message);
 
 void
-- 
2.35.2

  parent reply	other threads:[~2022-05-23 23:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-23 23:38 incrementally improve error handling in notmuch_message* David Bremner
2022-05-23 23:38 ` [PATCH 1/8] test: define test_private_C David Bremner
2022-05-23 23:38 ` [PATCH 2/8] lib/message: catch exceptions in _n_m_add_term David Bremner
2022-05-23 23:38 ` [PATCH 3/8] test: _notmuch_message_remove_term catches exceptions David Bremner
2022-05-23 23:38 ` David Bremner [this message]
2022-05-23 23:38 ` [PATCH 5/8] lib: define macro NODISCARD David Bremner
2022-05-23 23:38 ` [PATCH 6/8] lib/message: check return status of _n_m_{add,remove}_term David Bremner
2022-05-23 23:39 ` [PATCH 7/8] lib/message: check return status from _n_m_add_{path,folder}_terms David Bremner
2022-05-23 23:39 ` [PATCH 8/8] test: error handling in _n_message_{add,remove}_filename David Bremner
2022-06-25 19:00 ` incrementally improve error handling in notmuch_message* David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220523233901.3506880-5-david@tethera.net \
    --to=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).