From: Felipe Contreras <felipe.contreras@gmail.com>
To: notmuch@notmuchmail.org
Cc: Ali Polatel <alip@exherbo.org>
Subject: [PATCH 2/3] ruby: improve general data get helper
Date: Mon, 3 May 2021 02:54:56 -0500 [thread overview]
Message-ID: <20210503075457.649056-3-felipe.contreras@gmail.com> (raw)
In-Reply-To: <20210503075457.649056-1-felipe.contreras@gmail.com>
There's no need to do Check_Type, Data_Get_Struct calls
rb_data_object_get(), which already does that.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
bindings/ruby/defs.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/bindings/ruby/defs.h b/bindings/ruby/defs.h
index e95ea239..46e2caf8 100644
--- a/bindings/ruby/defs.h
+++ b/bindings/ruby/defs.h
@@ -57,10 +57,9 @@ extern ID ID_db_mode;
#define Data_Get_Notmuch_Object(obj, type, message, ptr) \
do { \
- Check_Type ((obj), T_DATA); \
- if (DATA_PTR ((obj)) == NULL) \
- rb_raise (rb_eRuntimeError, (message)); \
Data_Get_Struct ((obj), type, (ptr)); \
+ if (!(ptr)) \
+ rb_raise (rb_eRuntimeError, (message)); \
} while (0)
#define Data_Get_Notmuch_Database(obj, ptr) \
--
2.31.0
next prev parent reply other threads:[~2021-05-03 7:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 7:54 [PATCH 0/3] ruby: cleanups Felipe Contreras
2021-05-03 7:54 ` [PATCH 1/3] ruby: improve all Data_Get_Notmuch_* helpers Felipe Contreras
2021-05-03 7:54 ` Felipe Contreras [this message]
2021-05-03 7:54 ` [PATCH 3/3] ruby: simplify data get helper Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210503075457.649056-3-felipe.contreras@gmail.com \
--to=felipe.contreras@gmail.com \
--cc=alip@exherbo.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).