From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id JMEJOWGsj2AyCAEAgWs5BA (envelope-from ) for ; Mon, 03 May 2021 09:55:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 8F0UNGGsj2B8MgAAB5/wlQ (envelope-from ) for ; Mon, 03 May 2021 07:55:13 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A13B6133FA for ; Mon, 3 May 2021 09:55:13 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 3BD57271D4; Mon, 3 May 2021 03:55:07 -0400 (EDT) Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) by mail.notmuchmail.org (Postfix) with ESMTPS id 1C6131FAC2 for ; Mon, 3 May 2021 03:55:04 -0400 (EDT) Received: by mail-ot1-x32c.google.com with SMTP id f75-20020a9d03d10000b0290280def9ab76so4319935otf.12 for ; Mon, 03 May 2021 00:55:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=M3ZAIxW/pgpZ+jxxlx+mTTFmMbiwostVi77N/5d5LSg=; b=djQnjRDTjyIL1hokxupXv3OTitSHauYi8LPt3VvXGVuWm6UFD3uLhtCvAEy64t3iwN ghNLRGpasT8dZY5T1u8VRgEiBGm0OK0T+9qQofSlW5zXIqTNUTj4YJrurtPPvGkPBLQQ 1/FfZUY1HqrHKjJ+mgOueLCBjZKt32bnkVBsBzbcgXw3JIluMI56wVV3gc/sjRitfjUx 7bAVVF7pL1f4aoPGS/oyue0ehYA6TyQT9wx4Q2qse5aRG/35yrmT7rcTDviMhKovTrtv ztbck/FUKUegsYPeHFHqAhYkEfhRMOxHVZmCZ0adxe1f+BdcwAvGRJuIj7QaLoeTUDsm gugA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=M3ZAIxW/pgpZ+jxxlx+mTTFmMbiwostVi77N/5d5LSg=; b=FTgZij5vzJ6aJYFSBbgd3itpwW3qq/PFgsDmnOPSjeKTbP87uy9Z+u9IPIw9AGhymc XHj0hyqXqCDWywthVoUD10nsDtrClQzPUo8KaT83BQ49hSTLZ/SKL876ber3IkjAhzdx RMssuhVYG2Mai37U6pvXwHi5kNSx2L0gcP0FE5avHoVeQhZRVsaFAl4CODbT/yBefNdm 06nWd+XpWK0Qxlb93ab/u5nlrJIF9Fxs6p6YRfamv/LGN50ePzfKibdtq3vWVPbjO8ud y0u4/uOyk69J0rlmapt0dyXBfQIU8nawHdwimIu/qAn9W78OOvtEtTs5VnVj3KT3mJqm CNog== X-Gm-Message-State: AOAM5338T87Q1Gmg8rV8ZKHlS6EBczR53SH4id+rvr6Y4gy97PheayDL 0tk7inyOkrV8/QJ41JIzZ/PDKytaTeQ4mA== X-Google-Smtp-Source: ABdhPJxqLbKKMrvzFQ5iF8vvYHGgfull/hbFDQDJcuS2ZlQLgm24heS++ZldSW1tx1LQpee7OYbSIA== X-Received: by 2002:a9d:5a18:: with SMTP id v24mr14316970oth.350.1620028502959; Mon, 03 May 2021 00:55:02 -0700 (PDT) Received: from localhost ([2806:2f0:4060:638f:a2c5:89ff:fe0c:1151]) by smtp.gmail.com with ESMTPSA id i5sm2592381oos.38.2021.05.03.00.55.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 May 2021 00:55:02 -0700 (PDT) From: Felipe Contreras To: notmuch@notmuchmail.org Subject: [PATCH 2/3] ruby: improve general data get helper Date: Mon, 3 May 2021 02:54:56 -0500 Message-Id: <20210503075457.649056-3-felipe.contreras@gmail.com> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20210503075457.649056-1-felipe.contreras@gmail.com> References: <20210503075457.649056-1-felipe.contreras@gmail.com> MIME-Version: 1.0 Message-ID-Hash: 64WW32XU573UFXEXNRYNU2B733YE73NR X-Message-ID-Hash: 64WW32XU573UFXEXNRYNU2B733YE73NR X-MailFrom: felipe.contreras@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Ali Polatel X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1620028513; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=2wtJv20YcfuaG4dkbTaak/ftB3fDn1qssQi0ni6SSYc=; b=UKfQIof8iCl1trRm4NJLWf2Gi3eIYwQ03r85w/cnaWn0OfSVQ5eJD1Bz4p6RUIHI2Zoa/B RKTAnDum9aljaUbHj21zE5gHnXlOm7QZsmiW1pbeTIGL/TKfcWq3mt06cz2CI8Y69svygZ bZvlI2r2+XExzIg2Q5pc2UwD95hRxwr1gBeyNOWvSF1/zGcaKaVyNUUrbx1DSGUTtY8W5f uS9hypJDMuTJLT+rSBw6PKlda31lXxzKBFWoJs1sgw4FpXKQY4NCEEi+yJ6AwpRnUhFJyE wk1AoMGRulkZSnh9gwwC2TlCc4hpwK5092kOl7qE2rVQiwmO0uw031/Xh39zlQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1620028513; a=rsa-sha256; cv=none; b=p2OxBrofemXF/vVO3UF0xIzTGXTWelFzBeK0ecTiPVOna6FpZX8sttj95VBL7JI4cuSDNV Qs2J+S3tOvqYCeuXZTl9jyZRRcPc0wBUn/9W4jMGmaOCLGVh7hx4pueVZa0AxiV+xbm4kH 1WvHLN7AzdsOkb0H0Zhzsn+oTGJZxWv9S0HKONhndomvmSMgel9jmR9CnarvT6lMIB0GNT DMtUoSLGy1Jnp1qANvPk8yi9JQTN5qZxA8UsFrNOamKa3MkVvcJA9Y7D3SU8n4hpwXSixw tArCUjASUYUjwUYZPKjpK0LNWIOL+Ax4sndiK+gt01HeUrIjACClRmDVUS3cFQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gmail.com header.s=20161025 header.b=djQnjRDT; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: 0.53 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gmail.com header.s=20161025 header.b=djQnjRDT; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: A13B6133FA X-Spam-Score: 0.53 X-Migadu-Scanner: scn0.migadu.com X-TUID: +2LMgYw979oi There's no need to do Check_Type, Data_Get_Struct calls rb_data_object_get(), which already does that. Signed-off-by: Felipe Contreras --- bindings/ruby/defs.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/bindings/ruby/defs.h b/bindings/ruby/defs.h index e95ea239..46e2caf8 100644 --- a/bindings/ruby/defs.h +++ b/bindings/ruby/defs.h @@ -57,10 +57,9 @@ extern ID ID_db_mode; #define Data_Get_Notmuch_Object(obj, type, message, ptr) \ do { \ - Check_Type ((obj), T_DATA); \ - if (DATA_PTR ((obj)) == NULL) \ - rb_raise (rb_eRuntimeError, (message)); \ Data_Get_Struct ((obj), type, (ptr)); \ + if (!(ptr)) \ + rb_raise (rb_eRuntimeError, (message)); \ } while (0) #define Data_Get_Notmuch_Database(obj, ptr) \ -- 2.31.0