unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] test: check for GNU parallel with --version options
@ 2021-04-24 20:41 Tobias Backer Dirks
  2021-04-24 23:22 ` David Bremner
  0 siblings, 1 reply; 2+ messages in thread
From: Tobias Backer Dirks @ 2021-04-24 20:41 UTC (permalink / raw)
  To: notmuch; +Cc: Tobias Backer Dirks

The lastest versions of GNU parallel no longer make mention of GNU
within their help output. This causes the test script to mistakenly use
the moreutils parallel execution. In order to fix this, while
maintaining compatibility with previous versions of GNU parallel,
--version should be used.

Signed-off-by: Tobias Backer Dirks <omgitsaheadcrab@gmail.com>
---
 test/notmuch-test | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/notmuch-test b/test/notmuch-test
index b58fd3b3..91909264 100755
--- a/test/notmuch-test
+++ b/test/notmuch-test
@@ -50,7 +50,7 @@ META_FAILURE=
 # Run the tests
 if test -z "$NOTMUCH_TEST_SERIALIZE" && command -v parallel >/dev/null ; then
     test -t 1 && export COLORS_WITHOUT_TTY=t || :
-    if parallel -h | grep -q GNU ; then
+    if parallel --version | grep -q GNU ; then
         echo "INFO: running tests with GNU parallel"
         printf '%s\n' $TESTS | $TEST_TIMEOUT_CMD parallel
     else
-- 
2.31.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] test: check for GNU parallel with --version options
  2021-04-24 20:41 [PATCH] test: check for GNU parallel with --version options Tobias Backer Dirks
@ 2021-04-24 23:22 ` David Bremner
  0 siblings, 0 replies; 2+ messages in thread
From: David Bremner @ 2021-04-24 23:22 UTC (permalink / raw)
  To: Tobias Backer Dirks, notmuch

Tobias Backer Dirks <omgitsaheadcrab@gmail.com> writes:

> The lastest versions of GNU parallel no longer make mention of GNU
> within their help output. This causes the test script to mistakenly use
> the moreutils parallel execution. In order to fix this, while
> maintaining compatibility with previous versions of GNU parallel,
> --version should be used.

Applied, thanks!

d

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-24 23:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-24 20:41 [PATCH] test: check for GNU parallel with --version options Tobias Backer Dirks
2021-04-24 23:22 ` David Bremner

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).