* [WIP PATCH] test: make test-serially to run test serially
@ 2019-05-08 16:46 Tomi Ollila
2019-06-10 0:21 ` Daniel Kahn Gillmor
0 siblings, 1 reply; 2+ messages in thread
From: Tomi Ollila @ 2019-05-08 16:46 UTC (permalink / raw)
To: notmuch; +Cc: tomi.ollila
This is easier and less error prone than mistyping NOTMUCH_TEST_SERIALIZE
manually from command line (mistype make test-serially and it just doesn't
work)
---
quick first version. this works, but someone(tm) w/ native english experience
could say how the naming sounds like...
test/Makefile.local | 3 +++
1 file changed, 3 insertions(+)
diff --git a/test/Makefile.local b/test/Makefile.local
index 47244e8f0956..3c5e7e9cf33b 100644
--- a/test/Makefile.local
+++ b/test/Makefile.local
@@ -76,6 +76,9 @@ else
endif
endif
+test-serially: export NOTMUCH_TEST_SERIALIZE=t
+test-serially: test
+
check: test
SRCS := $(SRCS) $(test_srcs)
--
2.13.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [WIP PATCH] test: make test-serially to run test serially
2019-05-08 16:46 [WIP PATCH] test: make test-serially to run test serially Tomi Ollila
@ 2019-06-10 0:21 ` Daniel Kahn Gillmor
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Kahn Gillmor @ 2019-06-10 0:21 UTC (permalink / raw)
To: Tomi Ollila, notmuch
[-- Attachment #1: Type: text/plain, Size: 875 bytes --]
On Wed 2019-05-08 19:46:25 +0300, Tomi Ollila wrote:
> This is easier and less error prone than mistyping NOTMUCH_TEST_SERIALIZE
> manually from command line (mistype make test-serially and it just doesn't
> work)
> ---
>
> quick first version. this works, but someone(tm) w/ native english experience
> could say how the naming sounds like...
This is an unusual use of make in my experience (i'm not used to seeing
variables exported in what looks like a rule dependency line), but i'm
not particularly fluent in make in the first place, so take that with a
grain of salt.
As a native en_US speaker, i have no problem with "make test-serially"
(though my usual idiom is to invoke the test suite with "make check" for
some reason).
But if this is useful for even one person who actively cares about the
notmuch codebase (Tomi), i think it should be merged.
--dkg
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-10 11:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-08 16:46 [WIP PATCH] test: make test-serially to run test serially Tomi Ollila
2019-06-10 0:21 ` Daniel Kahn Gillmor
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).