unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] test: final named query test works regardless of Xapian FieldProcessor
@ 2017-12-19 16:27 Daniel Kahn Gillmor
  2017-12-21 13:41 ` David Bremner
  0 siblings, 1 reply; 2+ messages in thread
From: Daniel Kahn Gillmor @ 2017-12-19 16:27 UTC (permalink / raw)
  To: Notmuch Mail

This test passes with older versions of Xapian as well, because
neither query returns any results.

This should resolve the travis build failure at
https://travis-ci.org/notmuch/notmuch/builds/318571658

Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
---
 test/T600-named-queries.sh | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/test/T600-named-queries.sh b/test/T600-named-queries.sh
index e38dc5bb..abaee3b7 100755
--- a/test/T600-named-queries.sh
+++ b/test/T600-named-queries.sh
@@ -69,9 +69,6 @@ test_expect_equal_file EXPECTED OUTPUT
 test_begin_subtest "search nested named query"
 notmuch search query:test2 > OUTPUT
 notmuch search $QUERYSTR2 > EXPECTED
-if [ $NOTMUCH_HAVE_XAPIAN_FIELD_PROCESSOR -ne 1 ]; then
-    test_subtest_known_broken
-fi
 test_expect_equal_file EXPECTED OUTPUT
 
 test_done
-- 
2.15.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] test: final named query test works regardless of Xapian FieldProcessor
  2017-12-19 16:27 [PATCH] test: final named query test works regardless of Xapian FieldProcessor Daniel Kahn Gillmor
@ 2017-12-21 13:41 ` David Bremner
  0 siblings, 0 replies; 2+ messages in thread
From: David Bremner @ 2017-12-21 13:41 UTC (permalink / raw)
  To: Daniel Kahn Gillmor, Notmuch Mail

Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:

> This test passes with older versions of Xapian as well, because
> neither query returns any results.
>
> This should resolve the travis build failure at
> https://travis-ci.org/notmuch/notmuch/builds/318571658
>
> Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>

pushed to master.

d

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-12-21 13:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-19 16:27 [PATCH] test: final named query test works regardless of Xapian FieldProcessor Daniel Kahn Gillmor
2017-12-21 13:41 ` David Bremner

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).