* [PATCH] build: fix unbound variable in configure
@ 2017-08-31 11:46 Jan Malakhovski
2017-08-31 13:02 ` [PATCH] configure: add missing initialization of have_cppcheck David Bremner
2017-08-31 13:10 ` [PATCH] build: fix unbound variable in configure David Bremner
0 siblings, 2 replies; 3+ messages in thread
From: Jan Malakhovski @ 2017-08-31 11:46 UTC (permalink / raw)
To: notmuch
---
configure | 1 +
1 file changed, 1 insertion(+)
diff --git a/configure b/configure
index 364854f3..c0a550c7 100755
--- a/configure
+++ b/configure
@@ -651,6 +651,7 @@ if command -v cppcheck > /dev/null; then
have_cppcheck=1
printf "Yes.\n"
else
+ have_cppcheck=0
printf "No.\n"
fi
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] configure: add missing initialization of have_cppcheck
2017-08-31 11:46 [PATCH] build: fix unbound variable in configure Jan Malakhovski
@ 2017-08-31 13:02 ` David Bremner
2017-08-31 13:10 ` [PATCH] build: fix unbound variable in configure David Bremner
1 sibling, 0 replies; 3+ messages in thread
From: David Bremner @ 2017-08-31 13:02 UTC (permalink / raw)
To: notmuch
This missing initialization causes configure to crash, and hence the
build to fail in environments without cppcheck.
---
configure | 1 +
1 file changed, 1 insertion(+)
diff --git a/configure b/configure
index 364854f3..3ca1fcab 100755
--- a/configure
+++ b/configure
@@ -646,6 +646,7 @@ if [ $WITH_DESKTOP = "1" ]; then
fi
fi
+have_cppcheck=0
printf "Checking for cppcheck... "
if command -v cppcheck > /dev/null; then
have_cppcheck=1
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] build: fix unbound variable in configure
2017-08-31 11:46 [PATCH] build: fix unbound variable in configure Jan Malakhovski
2017-08-31 13:02 ` [PATCH] configure: add missing initialization of have_cppcheck David Bremner
@ 2017-08-31 13:10 ` David Bremner
1 sibling, 0 replies; 3+ messages in thread
From: David Bremner @ 2017-08-31 13:10 UTC (permalink / raw)
To: Jan Malakhovski, notmuch
Jan Malakhovski <oxij@oxij.org> writes:
> ---
> configure | 1 +
> 1 file changed, 1 insertion(+)
Thanks! I've pushed your fix, with some extra comments that I wrote more
or less in parallel.
d
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-31 13:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-31 11:46 [PATCH] build: fix unbound variable in configure Jan Malakhovski
2017-08-31 13:02 ` [PATCH] configure: add missing initialization of have_cppcheck David Bremner
2017-08-31 13:10 ` [PATCH] build: fix unbound variable in configure David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).