unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Vladimir Panteleev <notmuch@thecybershadow.net>
To: notmuch@notmuchmail.org
Subject: [PATCH 4/7] test: Fix T050-new.sh on some Travis CI machines
Date: Thu, 17 Aug 2017 17:51:42 +0000	[thread overview]
Message-ID: <20170817175145.3204-5-notmuch@thecybershadow.net> (raw)
In-Reply-To: <20170817175145.3204-1-notmuch@thecybershadow.net>

On some system configurations, setting a breakpoint on the "add_file"
function then issuing "continue" in gdb causes the debugger to
seemingly jump over the add_file invocation. This results in a test
failure, as the "Handle files vanishing between scandir and add_file"
subtest expects add_file to be called and fail due to the vanishing
file. The compiler optimization level also plays a role - the problem
can be reproduced with CFLAGS having -O2 but not -Og.

This problem was observed manifesting as a test failure on Travis CI
configured with "dist: trusty" and "sudo: false". It was not
reproducible on a local Docker image of Travis' runtime environment,
so Travis' virtualization infrastructure likely plays a role as well.

* T050-new.sh: Breakpoint notmuch_database_add_message instead of
  add_file to the same effect, and avoid bad gdb behaviour on Travis
  CI.
---
 test/T050-new.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/T050-new.sh b/test/T050-new.sh
index ffa303ef..8b7ac4e1 100755
--- a/test/T050-new.sh
+++ b/test/T050-new.sh
@@ -309,7 +309,7 @@ cat <<EOF > notmuch-new-vanish.gdb
 set breakpoint pending on
 set logging file notmuch-new-vanish-gdb.log
 set logging on
-break add_file
+break notmuch_database_add_message
 commands
 shell rm -f ${MAIL_DIR}/vanish
 continue
-- 
2.13.3

  parent reply	other threads:[~2017-08-17 17:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-17 17:51 [PATCH 0/7] Travis and test suite improvements Vladimir Panteleev
2017-08-17 17:51 ` [PATCH 1/7] .travis.yml: Invoke `make download-test-databases' before running tests Vladimir Panteleev
2017-08-17 17:51 ` [PATCH 2/7] .travis.yml: Add gdb and gpgsm dependencies Vladimir Panteleev
2017-08-17 17:51 ` [PATCH 3/7] .travis.yml: Replace manual zlib installation with "dist: trusty" Vladimir Panteleev
2017-08-17 17:51 ` Vladimir Panteleev [this message]
2017-08-17 17:51 ` [PATCH 5/7] .travis.yml: Switch to "sudo: false" for faster builds Vladimir Panteleev
2017-08-17 17:51 ` [PATCH 6/7] test: Fix T350-crypto.sh on Emacs snapshots Vladimir Panteleev
2017-09-02  0:11   ` [PATCH] test/crypto: remove headers more robustly David Bremner
2017-09-02 19:48     ` Tomi Ollila
2017-09-03 11:13       ` David Bremner
2017-08-17 17:51 ` [PATCH 7/7] .travis.yml: Test against several Emacs versions Vladimir Panteleev
2017-09-02  0:41   ` David Bremner
2017-09-04 21:31     ` Vladimir Panteleev
2017-08-30 23:19 ` [PATCH 0/7] Travis and test suite improvements David Bremner
2017-08-30 23:22   ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170817175145.3204-5-notmuch@thecybershadow.net \
    --to=notmuch@thecybershadow.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).